8000 Add a benchmark for kRing on a pentagon by isaacbrodsky · Pull Request #144 · uber/h3 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add a benchmark for kRing on a pentagon #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2018
Merged

Add a benchmark for kRing on a pentagon #144

merged 2 commits into from
Sep 5, 2018

Conversation

isaacbrodsky
Copy link
Collaborator

This case falls back to the DFS approach which is much slower
than non-pentagon cases.

Add a benchmark for kRing on a pentagon
9a0bf2f 
This case falls back to the DFS approach which is much slower
than non-pentagon cases.
nrabinowitz
nrabinowitz approved these changes Sep 4, 2018
View reviewed changes
Copy link
Collaborator
@nrabinowitz nrabinowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you mind posting the new benchmark results when you add a benchmark, just to give the reviewer a sense of scale?

src/apps/benchmarks/benchmarkKRing.c Outdated
BEGIN_BENCHMARKS();

setH3Index(&pentagon, 9, 4, CENTER_DIGIT);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but I don't see any issue just using the indexes of "well-known pentagons" directly in tests. If you tell me a test address is a pentagon, I'll believe you :).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to first calculate the index of the pentagon :)

@coveralls
Copy link
coveralls commented Sep 4, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling c6901f1 on isaacbrodsky:benchmark-kring-pentagon into f4f4658 on uber:master.

@isaacbrodsky
Copy link
Collaborator Author

Here's a sample run:

	-- kRing10: 26.303700 microseconds per iteration (10000 iterations)
	-- kRing20: 97.999600 microseconds per iteration (10000 iterations)
	-- kRing30: 216.685200 microseconds per iteration (10000 iterations)
	-- kRing40: 378.882100 microseconds per iteration (10000 iterations)
	-- kRingPentagon10: 724.058000 microseconds per iteration (500 iterations)
	-- kRingPentagon20: 6407.490000 microseconds per iteration (500 iterations)
	-- kRingPentagon30: 20842.580000 microseconds per iteration (50 iterations)
	-- kRingPentagon40: 47637.800000 microseconds per iteration (10 iterations)

@isaacbrodsky isaacbrodsky mentioned this pull request Sep 5, 2018
Closed
@isaacbrodsky isaacbrodsky merged commit dfcb55e into uber:master Sep 5, 2018
@isaacbrodsky isaacbrodsky deleted the benchmark-kring-pentagon branch September 5, 2018 20:53
mrdvt92 pushed a commit to mrdvt92/h3 that referenced this pull request Jun 19, 2022
@isaacbrodsky
Merge pull request uber#144 from isaacbrodsky/benchmark-kring-pentagon
3339dd5 
Add a benchmark for kRing on a pentagon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrabinowitz nrabinowitz nrabinowitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isaacbrodsky @coveralls @nrabinowitz
0