Fix binding-functions when building out of source #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfellis
approved these changes
Feb 13, 2019
|
This looks good, but can we add a Travis test that verifies |
nrabinowitz
approved these changes
Feb 13, 2019
nrabinowitz
reviewed
Feb 14, 2019
appveyor.yml
Outdated
| @@ -39,7 +39,10 @@ environment: | |||
| build_script: | |||
| - cmake "-G%GENERATOR%" -H. -Bbuild | |||
| - cmake --build build --config "%CONFIG%" | |||
| # Intentionally failing the build to check the test | |||
| #- cmake --build build --config "%CONFIG%" binding-functions | |||
There was a problem hiding this comment.
Should this still be here? Does leaving it commented out imply that the test should fail but doesn't?
There was a problem hiding this comment.
The test should fail, but it just emits an error message and marks it as succeeded anyways. I'd like to take a look at that tomorrow and see if I can get it working before merging.
There was a problem hiding this comment.
I updated the PR so Appveyor also tests the binding-functions target.
mrdvt92
pushed a commit
to mrdvt92/h3
that referenced
this pull request
Jun 19, 2022
…f-source Fix binding-functions when building out of source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binding functions scripts were looking in the original source directory, rather than for the generated
h3api.hwhich is now under the binary directory. Also updatedbinding_functions.shto fail the build when the file it expects is not found.