binding-functions encoded in ASCII on Windows #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default is for Powershell to generate UTF-16 with BOM, and setting to UTF-8 also generates a BOM. (I understand newer versions of Powershell have a UTF8 with no BOM option, but that wasn't available for me.) The BOM is a problem because Java for example does not discard the BOM, requiring workarounds like Commons IO. This limits function names in the C API to the ASCII character set, which currently appears to be a reasonable limitation.
nrabinowitz
approved these changes
Feb 21, 2019
dfellis
approved these changes
Feb 21, 2019
|
I confirmed in H3-Java / Appveyor that this does work: https://github.com/isaacbrodsky/h3-java/tree/bump-3.4.0-test-with-newer-h3 |
mrdvt92
pushed a commit
to mrdvt92/h3
that referenced
this pull request
Jun 19, 2022
binding-functions encoded in ASCII on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default is for Powershell to generate UTF-16 with BOM, and setting to UTF-8
also generates a BOM. (I understand newer versions of Powershell have a UTF8
with no BOM option, but that wasn't available for me.) The BOM is a problem
because Java for example does not discard the BOM, requiring workarounds like
Commons IO.
This limits function names in the C API to the ASCII character set, which
currently appears to be a reasonable limitation.