8000 Better test verification by sidepelican · Pull Request #304 · uber/mockolo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Better test verification #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 18, 2025
Merged

Better test verification #304

merged 7 commits into from
May 18, 2025

Conversation

sidepelican
Copy link
Collaborator

Issue

Solution

  • Modify the @Fixture macro to make it easy to include ConcurrencyHelper.

Changes

  • Add an option to the @Fixture macro so that ConcurrencyHelper can be included.
  • Also allow import statements to be specified.
  • Display diffs for parts that differ from the Fixture.
  • Visualize failed test cases.
  • Rewrite TestableImportStatementsTests using the @Fixture macro.

sidepelican
sidepelican commented Apr 26, 2025
View reviewed changes
Tests/MockoloTestCase.swift
let diff = lightDiff(old: outputContents, new: fixtureContents)
if !diff.isEmpty {
print("output:\n\(output)")
XCTFail("diff:\n" + "\(diff.joined(separator: "\n"))", file: file, line: line)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example:

スクリーンショット 2025-04-26 14 33 33

@sidepelican sidepelican requested a review from fummicc1 April 27, 2025 01:37
fummicc1
fummicc1 approved these changes May 17, 2025
View reviewed changes
Copy link
Collaborator
@fummicc1 fummicc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sidepelican sidepelican merged commit 1d1bcdc into uber:master May 18, 2025
29 of 37 checks passed
@sidepelican sidepelican deleted the better_test branch May 18, 2025 06:20
@BrewTestBot BrewTestBot mentioned this pull request May 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fummicc1 fummicc1 fummicc1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sidepelican @fummicc1
0