8000 Add gap alias prop to Stack Component by 8845musign · Pull Request #143 · ubie-oss/ubie-ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add gap alias prop to Stack Component #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

8845musign
Copy link
Contributor

Changes

add gap prop
an alias for spacing prop
only one of the two props can be specified

スクリーンショット 2024-11-15 17 05 59

Check

  • [-] Browser verification (minimum) Android Chrome/iOS Safari(375px-)
  • [-] CSS not affected by inheritance
  • [-] Layout does not break even if there is an overflow
  • [-] Layout does not break when wraps
  • [-] Added new Component
    • Added data-* prop and id prop
  • [-] Updated Ubie Vitals or Added an update issue(if needed)

@@ -143,7 +143,7 @@ export const Width: Story = {

export const Gap: Story = {
render: () => (
<Stack spacing="md">
<Stack gap="md">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The STORY name did not match the reality.

@8845musign 8845musign self-assigned this Nov 15, 2024
@takanorip takanorip merged commit 8751851 into ubie-oss:main Nov 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0