8000 Add wide leading to Text (body, heading) by tatsuroro · Pull Request #153 · ubie-oss/ubie-ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add wide leading to Text (body, heading) #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2025
Merged

Add wide leading to Text (body, heading) #153

merged 2 commits into from
Apr 21, 2025
+113 −40

Conversation

tatsuroro
Copy link
Contributor
@tatsuroro tatsuroro commented Apr 18, 2025 •
edited
Loading

Changes

  • use design-token 0.3.3
  • Add wide leading attr to Text component (type: body heading)

Check

  • Browser verification (minimum) Android Chrome/iOS Safari(375px-)
  • CSS not affected by inheritance
  • Layout does not break even if there is an overflow
  • Layout does not break when wraps
  • Added new Component
    • Added data-* prop and id prop
  • Updated Ubie Vitals or Added an update issue(if needed)

@tatsuroro tatsuroro self-assigned this Apr 18, 2025
@tatsuroro
Bump design token to 0.3.3
05f6d12 
Signed-off-by: Tatsuro Nakamura <me@tatsuroro.com>
@tatsuroro
Add wide leading option for Text component
1ddb6d5 
Signed-off-by: Tatsuro Nakamura <me@tatsuroro.com>
@tatsuroro tatsuroro force-pushed the add-wide-typography branch from c8c3387 to 1ddb6d5 Compare April 18, 2025 09:36
@tatsuroro tatsuroro merged commit 0dcd473 into main Apr 21, 2025
3 checks passed
@tatsuroro tatsuroro deleted the add-wide-typography branch April 21, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

@chihokotaro chihokotaro Awaiting requested review from chihokotaro

@tonkotsuboy tonkotsuboy Awaiting requested review from tonkotsuboy

Assignees

@tatsuroro tatsuroro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tatsuroro @sosukesuzuki
0