8000 Fix overlapping suffixIcon when button is in loading state by tatsuroro · Pull Request #154 · ubie-oss/ubie-ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix overlapping suffixIcon when button is in loading state #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2025
Merged

Fix overlapping suffixIcon when button is in loading state #154

merged 1 commit into from
Apr 21, 2025
+5 −1

Conversation

tatsuroro
Copy link
Contributor

Changes

  • Apply loading state to Button component suffix icon
    • Hide suffix icon while loading

Check

  • Browser verification (minimum) Android Chrome/iOS Safari(375px-)
  • CSS not affected by inheritance
  • Layout does not break even if there is an overflow
  • Layout does not break when wraps
  • Added new Component
    • Added data-* prop and id prop
  • Updated Ubie Vitals or Added an update issue(if needed)

@tatsuroro
Fix overlapping suffixIcon when button is in loading state
27240c1 
Signed-off-by: Tatsuro Nakamura <me@tatsuroro.com>
A3CA
@tatsuroro tatsuroro self-assigned this Apr 18, 2025
@tatsuroro tatsuroro requested review from chihokotaro, sosukesuzuki and tonkotsuboy and removed request for chihokotaro April 18, 2025 09:58
@tatsuroro tatsuroro merged commit 6d35c17 into main Apr 21, 2025
3 checks passed
@tatsuroro tatsuroro deleted the fix-button-loading-with-suffix-icon branch April 21, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

@tonkotsuboy tonkotsuboy Awaiting requested review from tonkotsuboy

Assignees

@tatsuroro tatsuroro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tatsuroro @sosukesuzuki
0