chore: devcontainer update #867
Merged
+60
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support the new vscode-containers extension and setup settings Fix startup script Remove digest pinning for the devcontainer Containerfile
add gh
bsherman
approved these changes
May 13, 2025
p5
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some minor issues with the devcontainer.
It configures the new VSCode containers extension to work when inside the devcontainer. Removes the older docker extension (unfortunately there are still popups to install it but they are mutually exclusive)
Additionally adds gh-cli if you do not want to do git credential forwarding and want to do authenticated api calls to gh.
Lastly, it removes the digest pin for the devcontainer and configures renovate to ignore it. This should reduce some of the notification spam for something not part of our critical path and resolves quay image garbage collection.