8000 fix: (#83) unmarshall rpmostree digest by jardon · Pull Request #84 · ublue-os/uupd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: (#83) unmarshall rpmostree digest #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

jardon
Copy link
Contributor
@jardon jardon commented May 28, 2025

the ostree.manifest-digest field of the rpmostree output is nested under the base-commit-meta field. this PR creates a sub struct to correctly unmarshall the contents. without this, the digest is an empty string and will always fail the comparison.

closes #83

@jardon jardon force-pushed the fix/update-check-failure branch from 38f7ba8 to 4c39fc4 Compare May 28, 2025 13:14
@jardon jardon changed the title fix:[#83] unmarshall rpmostree digest fix: (#83) unmarshall rpmostree digest May 28, 2025
Copy link
Collaborator
@gerblesh gerblesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@gerblesh gerblesh merged commit 277641f into ublue-os:main May 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update-check returns true even with no update available
2 participants
0