-
Notifications
You must be signed in to change notification settings - Fork 47
Add default arborist url #1235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add default arborist url #1235
Conversation
Pull Request Test Coverage Report for Build 14455830332Details
💛 - Coveralls |
This is a reasonable default, but not without potential issue. At the very least, we should update "Deployment changes" so commons that are not running arborist are aware they'll need to explicitly set this to null in their fence-config.yaml secret. Otherwise, this line: Line 480 in dccf559
will cause a lot of issues if arborist isn't reachable or deployed. |
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
@@ -751,7 +751,7 @@ AZ_BLOB_CREDENTIALS: | |||
AZ_BLOB_CONTAINER_URL: 'https://myfakeblob.blob.core.windows.net/my-fake-container/' | |||
|
|||
# url where authz microservice is running | |||
ARBORIST: null | |||
ARBORIST: 'http://arborist-service' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine but it's a breaking chance, by default fence will assume arborist is used. Can you update the PR description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine but it's a breaking chance, by default fence will assume arborist is used. Can you update the PR description
Updated breaking changes section.
Updated deployment changes. |
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
Link to JIRA ticket if there is one:
New Features
Breaking Changes
ARBORIST: null
in your fence configuration.Bug Fixes
Improvements
Dependency updates
Deployment changes
ARBORIST: null
in your fence configuration.