8000 Update ICV defaults for RHEL9, fix version_number() by daniellovell · Pull Request #886 · ucb-bar/hammer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update ICV defaults for RHEL9, fix version_number() #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 7, 2025
Merged

Update ICV defaults for RHEL9, fix version_number() #886

merged 5 commits into from
Mar 7, 2025

Conversation

daniellovell
Copy link
Collaborator
@daniellovell daniellovell commented Feb 28, 2025 •
edited
Loading

The BWRC servers migrated to RHEL9, and with that, our old setup using S-2021.06-SP3-2 for the default ICV version is not functional.

In general, users of RHEL9 should adopt W-2024.09-4 for ICV and V-2023.09-SP2 for ICVWB.

Synopsys now defaults to install these newer ICV versions at the /icvalidator/ directory instead of /icv/, so the ICV_HOME env var should reflect this.

Finally, SynopsysTool.version_number() fails to correctly parse W-2024.09-4:
image

This change fixes that, and includes regression unit tests to ensure previous versions of ICV can still be successfully parsed

Related PRs / Issues
Related to this PR for hammer-intech22-plugin https://bwrcrepo.eecs.berkeley.edu/intech22/hammer-intech22-plugin/-/merge_requests/72

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer
  • Change to a Hammer plugin
  • Other

Contributor Checklist:

  • Did you set master as the base branch?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?
  • (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

@daniellovell
Update ICV defaults for RHEL9, fix version_number()
8d63086 
The BWRC servers migrated to RHEL9, and with that, our old
setup using S-2021.06-SP3-2 for the default ICV version
is not functional.

In general, users of RHEL9 should adopt W-2024.09-4 from Synopsys
for ICV and V-2023.09-SP2 for ICVWB.

Synopsys now defaults to install these newer ICV versions
at the /icvalidator/ directory instead of /icv/, so
the ICV_HOME env var should reflect this.

Finally, SynopsysTool.version_number() fails to correctly
parse W-2024.09-4. This change fixes that, and includes
regression unit tests to ensure previous versions of ICV
can still be successfully parsed
@daniellovell
Fix test_synopsys_tool static analyzer test failure
9394afa
@daniellovell daniellovell mentioned this pull request Feb 28, 2025
Merged
14 tasks
@daniellovell
Copy link
Collaborator Author

Should pass all checks if #887 is merged.

@daniellovell
Copy link
Collaborator Author
daniellovell commented Mar 1, 2025 •
edited
Loading

Note: the fact that this changes the default ICV directory to /icvalidator/ is a somewhat troublesome change. Users who want to use an older version of icv in their icv.version will always need to change the ICV_HOME directory as well. That is to say, this isn't really backward compatible with older default ICV installation directories (/icv/VERSION_NUM). It is forward compatible with Synopsys's new default ICV installation directories (/icvalidator/VERSION_NUM)

@daniellovell daniellovell changed the title [DRAFT] Update ICV defaults for RHEL9, fix version_number() Update ICV defaults for RHEL9, fix version_number() Mar 1, 2025
@daniellovell
Copy link
Collaborator Author

Tested a few runs of ICV DRC, then used the generated-scripts/view_drc to pop open ICVWB successfully.
Removed the DRAFT tag

Ready to be reviewed

elamdf
elamdf requested changes Mar 6, 2025
View reviewed changes
daniellovell
daniellovell commented Mar 6, 2025
View reviewed changes
@daniellovell
Add comment to icv/defaults.yml for old ICV versions
1bcd48b 
Old ICV (<2024) versions will be found at /icv/ instead
of /icvalidator/
@daniellovell daniellovell requested a review from elamdf March 7, 2025 00:24
@daniellovell
Copy link
Collaborator Author

Recommend that this is merged together with https://bwrcrepo.eecs.berkeley.edu/intech22/hammer-intech22-plugin/-/merge_requests/72

elamdf
elamdf approved these changes Mar 7, 2025
View reviewed changes
Copy link
Collaborator
@elamdf elamdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Maybe someone like @kenhoberkeley can review + merge the intech PR, I don't have write access to that one

@daniellovell daniellovell added this pull request to the merge queue Mar 7, 2025
Merged via the queue into ucb-bar:master with commit 4192f3b Mar 7, 2025
4 checks passed
@daniellovell daniellovell deleted the fix-icv-rhel9 branch March 7, 2025 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elamdf elamdf elamdf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniellovell @elamdf
0