Management frontend: Improve clarity of response messages #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test FAILed. |
|
jenkins test this please |
|
Test FAILed. |
|
jenkins test this please |
|
Test PASSed. |
Corey-Zumar
added a commit
to dcrankshaw/clipper
that referenced
this pull request
Sep 12, 2017
* rpc test infra change * rpcbench more * bench, metrics fix * concurrent queue for rpc * Add send/recv balance to rpc bench * multi container bench * add concurrent queue * fix end_to_end bench * [CLIPPER-224] Replace boost futures with folly futures (ucbrise#266) * replace boost futures with folly * Remove unused futures code * some code formatting * Update query frontend dockerfile to support Folly * fix cache move issue * remove unused import * format code * remove version check * remove boost thread dependency * remove boost thread as required component * format code * Create base dockerfile for installing clipper deps, query and mgmt inherit from this base * rename lib-base >> lib_base * makes FindFolly.cmake search in FOLLY_ROOT * format code * Pin library versions in base dockerfile * Fix FindFolly cmake * Add additional link flags for folly cmake * Add missing threadpool imports * fix boost thread import * Add more cmake link flags * Revert "Add more cmake link flags" This reverts commit 5604672. * Update QueryFrontendDockerfile * Update ManagementFrontendDockerfile * query proc return default future * grpc benchmark script * Add request throughput meter to grpc frontend * change meter name * Add metrics reporting * update grpc bench * fixes * frontend fixes * update grpc benchmark * multiproc changes * more bench fixes * allow query proc to flourish * logging perf * batch size log * Management frontend: Improve clarity of response messages (ucbrise#271) * format code * Update clipper mgr register external output * logs * queue size * Fix histogram overflow errors (ucbrise#272) * Recalculate mean on insertion, improve histogram data precision and value capacity * Format code * Implement CLOCK policy * add cache tests * revert clipper mgr changes * remove quotes * add test assertion * format code * Refactor PredictionCache to evict based on byte size rather than num pages * Add config flag for cache size * Format code * Update config tests * format code * Update config.hpp * Remove unused task executor threadpool size config * Add cache size option to clipper mgr * format code * remove task execution variable * when evicting, stop if we're out of pages * remove task execution test statement * Fix rebase issue * updates * fix * qp limit * fix * fix test * qp lat * fix * fox * test * test2 * test3 * test4 * test5 * Wangle * more wangle * threadpool * .. * link wangle * bench log * update * .. * test * test * testfix * test2 * fixes * var naming * more metrics * time diff * .. * one more metric change * queue insert metric * more seg monitor * measure something that probably isn't the issue * measure something that probably is the problem * fixes * hopeful move fix * measure other part of cache * measure cache put * measure with some wangle * wangle with the frontend * more measure * hone measurement * try fix * var issues * add move * make copy * Add a log * expect tid match * remove log * another continuation change * bump hist size * change cache seg to fetch * urgh * hm * fix segfault * var naming * fix merge issues * measure cache insertion latency * cache eviction * cache unique ptr * fix method prototype * fixes * remove hit ratio * remove lookups counter * bench other seg * metric move * change qp seg hist * move hist * .. * hist size * ... * send/recv balance * meterfix * remove metrics * experiment * varfix * .. * ... * .. * logging * varfix * why * measure elsewhere * measure thread task lat * compfixes * compfix2 * compfix3 * fail to fix seg fault * fix segfault * get num steps * time first pass * track queue insertion * log output * Add moar ctx * Remove log * .. * Add a logging tag * varfix * zmq frontend * cmake fix * import fixes * remove grpc stuff * fixes * more fixes * fixes again * fix * zmq client * varfox * add socket bind * string conversion * update * .. * .... * test * ... * protocol fix * fix? * fail * fix polling * client fix * api fix * fixes * actually add the application to rpc * debug * bench fix * client logs * client log * new log * Add hash checks * remove a log * log * test * routing id log * cmake fix * import fix * client fix * routing id fix * .. * constness * try again * prototype changes * constness * constness * client test * client test * more routing id logs' * remove ref * remove move * routing id rpc log * ... * req id int * ordering * fix really dumb error * prototype fixes * client throughput logging * client fix * client fix2 * units * .. * .. * clean up task executor * cleanup qp * cleanup * bench update * remove unnecessary file handles from grpc bench * remove unused chron statements * re-add deadline comparator
Corey-Zumar
added a commit
to dcrankshaw/clipper
that referenced
this pull request
Sep 21, 2017
* query proc return default future * grpc benchmark script * Add request throughput meter to grpc frontend * change meter name * Add metrics reporting * update grpc bench * fixes * frontend fixes * update grpc benchmark * multiproc changes * more bench fixes * allow query proc to flourish * logging perf * batch size log * Management frontend: Improve clarity of response messages (ucbrise#271) * format code * Update clipper mgr register external output * logs * queue size * Fix histogram overflow errors (ucbrise#272) * Recalculate mean on insertion, improve histogram data precision and value capacity * Format code * Implement CLOCK policy * add cache tests * revert clipper mgr changes * remove quotes * add test assertion * format code * Refactor PredictionCache to evict based on byte size rather than num pages * Add config flag for cache size * Format code * Update config tests * format code * Update config.hpp * Remove unused task executor threadpool size config * Add cache size option to clipper mgr * format code * remove task execution variable * when evicting, stop if we're out of pages * remove task execution test statement * Fix rebase issue * updates * fix * qp limit * fix * fix test * qp lat * fix * fox * test * test2 * test3 * test4 * test5 * Wangle * more wangle * threadpool * .. * link wangle * bench log * update * .. * test * test * testfix * test2 * fixes * var naming * more metrics * time diff * .. * one more metric change * queue insert metric * more seg monitor * measure something that probably isn't the issue * measure something that probably is the problem * fixes * hopeful move fix * measure other part of cache * measure cache put * measure with some wangle * wangle with the frontend * more measure * hone measurement * try fix * var issues * add move * make copy * Add a log * expect tid match * remove log * another continuation change * bump hist size * change cache seg to fetch * urgh * hm * fix segfault * var naming * fix merge issues * measure cache insertion latency * cache eviction * cache unique ptr * fix method prototype * fixes * remove hit ratio * remove lookups counter * bench other seg * metric move * change qp seg hist * move hist * .. * hist size * ... * send/recv balance * meterfix * remove metrics * experiment * varfix * .. * ... * .. * logging * varfix * why * measure elsewhere * measure thread task lat * compfixes * compfix2 * compfix3 * fail to fix seg fault * fix segfault * get num steps * time first pass * track queue insertion * log output * Add moar ctx * Remove log * .. * Add a logging tag * varfix * zmq frontend * cmake fix * import fixes * remove grpc stuff * fixes * more fixes * fixes again * fix * zmq client * varfox * add socket bind * string conversion * update * .. * .... * test * ... * protocol fix * fix? * fail * fix polling * client fix * api fix * fixes * actually add the application to rpc * debug * bench fix * client logs * client log * new log * Add hash checks * remove a log * log * test * routing id log * cmake fix * import fix * client fix * routing id fix * .. * constness * try again * prototype changes * constness * constness * client test * client test * more routing id logs' * remove ref * remove move * routing id rpc log * ... * req id int * ordering * fix really dumb error * prototype fixes * client throughput logging * client fix * client fix2 * units * .. * .. * clean up task executor * cleanup qp * cleanup * bench update * remove unnecessary file handles from grpc bench * remove unused chron statements * re-add deadline comparator * attempt batching fix * fix * variable change * Split sockets and threads * Client changes * zmq bench update * bug fixes * fix * fix * client fix * var init * logging * log debug * log debug * zmq flags fix * fix2 * debug * fix * client fix * make sleeps reasonable' * varfix * debug log * remove source of lock contention * import fix * varfix * id fix * .. * debug * .. * client id fix * routing lock fix * another lock fix * remove unnecessary logs * request id updates * client fix * log * Maybe fix * test script * update * fix * remove test file * revert logging
Corey-Zumar
added a commit
to dcrankshaw/clipper
that referenced
this pull request
Sep 21, 2017
* Add metrics reporting * update grpc bench * fixes * frontend fixes * update grpc benchmark * multiproc changes * more bench fixes * allow query proc to flourish * logging perf * batch size log * Management frontend: Improve clarity of response messages (ucbrise#271) * format code * Update clipper mgr register external output * logs * queue size * Fix histogram overflow errors (ucbrise#272) * Recalculate mean on insertion, improve histogram data precision and value capacity * Format code * Implement CLOCK policy * add cache tests * revert clipper mgr changes * remove quotes * add test assertion * format code * Refactor PredictionCache to evict based on byte size rather than num pages * Add config flag for cache size * Format code * Update config tests * format code * Update config.hpp * Remove unused task executor threadpool size config * Add cache size option to clipper mgr * format code * remove task execution variable * when evicting, stop if we're out of pages * remove task execution test statement * Fix rebase issue * updates * fix * qp limit * fix * fix test * qp lat * fix * fox * test * test2 * test3 * test4 * test5 * Wangle * more wangle * threadpool * .. * link wangle * bench log * update * .. * test * test * testfix * test2 * fixes * var naming * more metrics * time diff * .. * one more metric change * queue insert metric * more seg monitor * measure something that probably isn't the issue * measure something that probably is the problem * fixes * hopeful move fix * measure other part of cache * measure cache put * measure with some wangle * wangle with the frontend * more measure * hone measurement * try fix * var issues * add move * make copy * Add a log * expect tid match * remove log * another continuation change * bump hist size * change cache seg to fetch * urgh * hm * fix segfault * var naming * fix merge issues * measure cache insertion latency * cache eviction * cache unique ptr * fix method prototype * fixes * remove hit ratio * remove lookups counter * bench other seg * metric move * change qp seg hist * move hist * .. * hist size * ... * send/recv balance * meterfix * remove metrics * experiment * varfix * .. * ... * .. * logging * varfix * why * measure elsewhere * measure thread task lat * compfixes * compfix2 * compfix3 * fail to fix seg fault * fix segfault * get num steps * time first pass * track queue insertion * log output * Add moar ctx * Remove log * .. * Add a logging tag * varfix * zmq frontend * cmake fix * import fixes * remove grpc stuff * fixes * more fixes * fixes again * fix * zmq client * varfox * add socket bind * string conversion * update * .. * .... * test * ... * protocol fix * fix? * fail * fix polling * client fix * api fix * fixes * actually add the application to rpc * debug * bench fix * client logs * client log * new log * Add hash checks * remove a log * log * test * routing id log * cmake fix * import fix * client fix * routing id fix * .. * constness * try again * prototype changes * constness * constness * client test * client test * more routing id logs' * remove ref * remove move * routing id rpc log * ... * req id int * ordering * fix really dumb error * prototype fixes * client throughput logging * client fix * client fix2 * units * .. * .. * clean up task executor * cleanup qp * cleanup * bench update * remove unnecessary file handles from grpc bench * remove unused chron statements * re-add deadline comparator * attempt batching fix * fix * variable change * Split sockets and threads * Client changes * zmq bench update * bug fixes * fix * fix * client fix * var init * logging * log debug * log debug * zmq flags fix * fix2 * debug * fix * client fix * make sleeps reasonable' * varfix * debug log * remove source of lock contention * import fix * varfix * id fix * .. * debug * .. * client id fix * routing lock fix * another lock fix * remove unnecessary logs * request id updates * client fix * log * Maybe fix * test script * update * fix * remove test file * revert logging * Support sending different data types from client * add self * data type mapping change for str * error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds documentation and cleans up code