8000 Clean up the versioned model's batch_size and metrics when deleting it by withsmilo · Pull Request #711 · ucbrise/clipper · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Clean up the versioned model's batch_size and metrics when deleting it #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 31, 2019
Merged

Clean up the versioned model's batch_size and metrics when deleting it #711

merged 4 commits into from
May 31, 2019

Conversation

withsmilo
Copy link
Collaborator

@withsmilo withsmilo self-assigned this May 30, 2019
rkooo567
rkooo567 previously approved these changes May 30, 2019
View reviewed changes
Copy link
Collaborator
@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@withsmilo
Copy link
Collaborator Author

@rkooo567 Wait. I will push one more commit to this PR.

@rkooo567 rkooo567 dismissed their stale review May 30, 2019 06:52

Will review again when new commit comes in

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/2044/
Test PASSed.

@withsmilo withsmilo changed the title Cleanup batch_size when deleting a versioned model Clean up the versioned model's batch_size and metrics when deleting it May 30, 2019
@withsmilo
Copy link
Collaborator Author

jenkins test this please

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/2047/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/2048/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/2049/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/2050/
Test PASSed.

@withsmilo withsmilo requested review from rkooo567 and simon-mo May 30, 2019 13:54
rkooo567
rkooo567 approved these changes May 31, 2019
View reviewed changes
Copy link
Collaborator
@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment< 8000 /h3>

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@rkooo567 rkooo567 merged commit 001f9d5 into ucbrise:develop May 31, 2019
@withsmilo withsmilo deleted the cleanup_batch_size branch May 31, 2019 03:51
@withsmilo withsmilo mentioned this pull request Jul 9, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkooo567 rkooo567 rkooo567 approved these changes

@simon-mo simon-mo Awaiting requested review from simon-mo

Assignees

@withsmilo withsmilo

Labels
status: accepted type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@withsmilo @AmplabJenkins @rkooo567
0