Added a utility of mHM2OGS #96
Conversation
|
@norihiro-w In this year, I am preparing the last version of ogs5, ogs5.8. The final version includes what are presented in the PR, merging what developed by BGR for decovelax, improvement in the excavation modelling, bugfixing, code cleaning and so on. Your comments are very appreciated! |
|
|
||
| 03/2010 WW | ||
| */ | ||
| void ReadShapeFile(std::string const& fname, RasterDataGIS& raster_data) |
| } | ||
|
|
||
| RasterDataGIS mHMPreprocessor::transfromSingle_mHMdataToNodalFlux( | ||
| std::string const& fname, std::string const& ofname, double ratio) |
There was a problem hiding this comment.
moved from msh_mesh.cpp and changed the name from Precipitation2NeumannBC
| delete _fem; | ||
| } | ||
|
|
||
| void mHMPreprocessor::transform_mHMData(const std::string& output_path) |
There was a problem hiding this comment.
moved from msh_mesh.cpp and changed the name from mHM2NeumannBC
198469f to
342f7bc
Compare
…path for the results
the direct assigning the precipitation data
moved the declartions of variables to the positions that are close to where they are used.
| vector<double> cell_data_p(size); | ||
| vector<double> cell_data_v(size); | ||
| for (i = 0; i < size; i++) | ||
| for (std::size_t i = 0; i < size; i++) |
There was a problem hiding this comment.
i is used in line 13620. please check if there is any problem
There was a problem hiding this comment.
There is no problem in computation but this variable name causes confusion. I have changed the source accordingly in the new commit.
MSH/msh_mesh.cpp
Outdated
| #endif | ||
| } | ||
| else | ||
| elem->SetMark(false); |
There was a problem hiding this comment.
are you sure if the element marks are set true at initial?
There was a problem hiding this comment.
Here the face elements on the top surface are marked by the condition of
n * z >0, where n is the normal vector of an face element, and z=(0, 0, 1)^T. The orientation of the normal vector is guaranteed by a vector from the the center of 3D element to an node of the face.
In this loop over face elements, elements that satisfy n * z >0 are marked as true, and the others are marked as false. Therefore there is no need to set initial status of the face elements.
There was a problem hiding this comment.
In the new commit, I moved the else if for the bottom surface to the section of #ifdef output_top_z.
|
@wenqing i have only minor comments |
|
@norihiro-w Thanks for your comments. |
|
looks good from my side |
This PR