(v3.6.1) pip install fix with pyproject.toml #449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Poetry and
pyproject.tomlare compatible with pip usage. However, a definition error previously prevented the installation of extras containing essential utilities for running experiments, should users wish to use them.This update ensures that development libraries are installed natively when running
poetry install. Nevertheless, some of them are marked as optional in the main dependencies so they can be used through extras.For more information on how container and workflow installations have been updated, the documentation in the installation section has been revised with much greater detail.
The list of extras is now separate from the development dependency groups, so the pip-installable extras are limited to DRL utilities and for running tests.
Types of changes
Checklist:
autopep8second level aggressive.isort.cd docs && make spelling && make htmlpass (required if documentation has been updated.)pytest tests/ -vvpass. (required).pytype -d import-error sinergym/pass. (required)Changelog: