8000 Flush convergence callback by je-cook · Pull Request #2956 · ukaea/PROCESS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Flush convergence callback #2956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2023
Merged

Flush convergence callback #2956

merged 1 commit into from
Oct 4, 2023

Conversation

je-cook
Copy link
Collaborator
@je-cook je-cook commented Sep 28, 2023 •
edited by timothy-nunn
Loading

Description

The implemented convergence callback for pyvmcon doesnt flush the print statement therefore in some situations the printing won't appear on stdout until a while later.
This enforces flushing after every update.

I have no idea how you would test this so I haven't.

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@je-cook je-cook assigned je-cook and timothy-nunn and unassigned je-cook Sep 28, 2023
timothy-nunn
timothy-nunn approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor
@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers James, do we have any idea why this was happening? Was it when PROCESS was being run as a subprocess?

@timothy-nunn timothy-nunn merged commit f474ba8 into ukaea:main Oct 4, 2023
@je-cook
Copy link
Collaborator Author
je-cook commented Oct 4, 2023

Cheers James, do we have any idea why this was happening? Was it when PROCESS was being run as a subprocess?

I was running in a subprocess yeah. It sometimes happens if stdout is redirected in some way. Seen it happen on our side too previously when we weren't running a subprocess (in another context not with PROCESS).

@je-cook je-cook deleted the flush_convergence branch October 4, 2023 12:29
chris-ashe pushed a commit that referenced this pull request Apr 22, 2024
@je-cook @chris-ashe
Flush convergence callback (#2956)
dd59d2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothy-nunn timothy-nunn timothy-nunn approved these changes

Assignees

@timothy-nunn timothy-nunn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@je-cook @timothy-nunn
0