8000 fix image displaying in readme by clmould · Pull Request #2975 · ukaea/PROCESS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix image displaying in readme #2975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix image displaying in readme #2975

merged 1 commit into from
Oct 23, 2023

Conversation

clmould
Copy link
Collaborator
@clmould clmould commented Oct 19, 2023 •
edited
Loading

Description

Blender image was not displaying in readme on github, have fixed this now so it does display as expected

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould linked an issue Oct 19, 2023 that may be closed by this pull request
fix displaying of blender image in readme #2974
Closed
@clmould clmould requested a review from jonmaddock October 19, 2023 09:58
timothy-nunn
timothy-nunn reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor
@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue of the image not being displayed. The bottom right quadrant looks lower resolution than the others, is there a way to improve the resolution of this?

@clmould
Copy link
Collaborator Author
clmould commented Oct 23, 2023

I don't think there's a way to fix this just yet (the image is not being generated by fusrr currently, it just exists in the fusrr repo as an example image and I copied it across to use in the process readme). I plan to update this image in the readme when there are more being produced by fusrr, and also add a hyperlink to fusrr when it's made public

@clmould clmould requested a review from timothy-nunn October 23, 2023 11:00
timothy-nunn
timothy-nunn approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor
@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the problem. I agree with your comment that the image can be updated as fusr improves.

@timothy-nunn timothy-nunn merged commit 4f6867b into main Oct 23, 2023
@timothy-nunn timothy-nunn deleted the 2974-fix-displaying-of-blender-image-in-readme branch October 23, 2023 11:02
chris-ashe pushed a commit that referenced this pull request Apr 22, 2024
@clmould @chris-ashe
fix image displaying in readme (#2975)
355d9de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothy-nunn timothy-nunn timothy-nunn approved these changes

@jonmaddock jonmaddock Awaiting requested review from jonmaddock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix displaying of blender image in readme
2 participants
@clmould @timothy-nunn
0