8000 Convert physics.f90 to Python by timothy-nunn · Pull Request #2993 · ukaea/PROCESS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Convert physics.f90 to Python #2993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2024
Merged

Convert physics.f90 to Python #2993

merged 1 commit into from
Jan 31, 2024

Conversation

timothy-nunn
Copy link
Contributor
@timothy-nunn timothy-nunn commented Nov 16, 2023 •
edited
Loading

Description

Converts the remaining physics.f90 module into Python

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@timothy-nunn timothy-nunn changed the title Convert physics' output to Python Convert physics.f90 to Python Nov 16, 2023
@timothy-nunn timothy-nunn force-pushed the convert-physics-to-python branch from e8bfb56 to 33b8d66 Compare November 16, 2023 17:22
@timothy-nunn timothy-nunn self-assigned this Nov 16, 2023
@timothy-nunn
Copy link
Contributor Author

When converting bootstrap_fraction_nevins to Python, I have replaced the quanc8 integrator with the scipy integrator. This is because...

  1. We cannot use the Fortran solver from Python (it requires a callable)
  2. It is ideal to use industry-standard solvers where possible

This causes the unit test, created from values seen in large-tokamak, to change from 886436144167.0579 to 889258771342.7881. @chris-ashe do you have any intuition as to how significant this change is?

@timothy-nunn timothy-nunn force-pushed the convert-physics-to-python branch from 04f422f to aac21e2 Compare November 22, 2023 15:21
@timothy-nunn timothy-nunn force-pushed the convert-physics-to-python branch from 71d05ba to 64ed103 Compare January 4, 2024 14:07
@timothy-nunn timothy-nunn force-pushed the convert-physics-to-python branch from 334ae8b to 5a6e6cb Compare January 17, 2024 10:02
@timothy-nunn timothy-nunn marked this pull request as ready for review January 17, 2024 10:11
jonmaddock
jonmaddock reviewed Jan 26, 2024
View reviewed changes
Copy link
Contributor
@jonmaddock jonmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Tim, huge one! Just a couple of chopped-off descriptions in the mfile output, but otherwise fine.

@timothy-nunn timothy-nunn force-pushed the convert-physics-to-python branch from d8c880a to e125e92 Compare January 29, 2024 10:29
@jonmaddock
Copy link
Contributor

Can't rebase due to conflicts. Can you sort these, then good to go in.

@timothy-nunn timothy-nunn force-pushed the convert-physics-to-python branch 2 times, most recently from c698cd1 to a48f373 Compare January 31, 2024 13:18
@timothy-nunn timothy-nunn force-pushed the convert-physics-to-python branch from a48f373 to 8add79e Compare January 31, 2024 13:30
@timothy-nunn timothy-nunn merged commit 8cb8c27 into main Jan 31, 2024
@timothy-nunn timothy-nunn deleted the convert-physics-to-python branch January 31, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonmaddock jonmaddock jonmaddock approved these changes

Assignees

@timothy-nunn timothy-nunn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timothy-nunn @jonmaddock
0