8000 152 PF coil by ajpearcey · Pull Request #3036 · ukaea/PROCESS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

152 PF coil #3036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 6, 2024
Merged

152 PF coil #3036

merged 6 commits into from
Feb 6, 2024

Conversation

ajpearcey
Copy link
Collaborator

closes #152

@ajpearcey ajpearcey changed the title 152 PF coil WIP: 152 PF coil Jan 29, 2024
@ajpearcey ajpearcey requested a review from jonmaddock February 5, 2024 10:01
jonmaddock
jonmaddock requested changes Feb 5, 2024
View reviewed changes
Copy link
Contributor
@jonmaddock jonmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content is fine, but there's a bit of back-and-forth and formatting fixes (perhaps check pre-commit is working with black alright?). Can you rebase and fixup these commits to condense them to reflect only the required changes?

@jonmaddock jonmaddock changed the title WIP: 152 PF coil 152 PF coil Feb 6, 2024
@jonmaddock jonmaddock merged commit bb5a94a into main Feb 6, 2024
@jonmaddock jonmaddock deleted the 152-pf-coil branch February 6, 2024 09:52
chris-ashe pushed a commit that referenced this pull request Apr 22, 2024
@ajpearcey @chris-ashe
152 PF coil (#3036)
9f31cf8 
* ✨ add pf current safety factor

* 🎨 black formatting

* ✏️ update varialbe description

* 🎨 remove change to fdene bound

* 🐛 fix default SF value

* ✅ update large tokamak to pass regression test

---------

Co-authored-by: apearce <alexaner.pearce@ukaea.uk>
chris-ashe pushed a commit that referenced this pull request May 1, 2024
@ajpearcey @chris-ashe
152 PF coil (#3036)
b912a5d 
* ✨ add pf current safety factor

* 🎨 black formatting

* ✏️ update varialbe description

* 🎨 remove change to fdene bound

* 🐛 fix default SF value

* ✅ update large tokamak to pass regression test

---------

Co-authored-by: apearce <alexaner.pearce@ukaea.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonmaddock jonmaddock jonmaddock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PF coils
2 participants
@ajpearcey @jonmaddock
0