8000 correct error message when acs negative by clmould · Pull Request #3092 · ukaea/PROCESS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

correct error message when acs negative #3092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 14, 2024
Merged

correct error message when acs negative #3092

merged 3 commits into from
Mar 14, 2024

Conversation

clmould
Copy link
Collaborator
@clmould clmould commented Mar 6, 2024

Description

Closes #537

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould linked an issue Mar 6, 2024 that may be closed by this pull request
Error handling for negative conductor fraction in TF cable #537
Closed
@clmould clmould self-assigned this Mar 6, 2024
@clmould clmould marked this pull request as ready for review March 13, 2024 15:15
@clmould clmould requested a review from timothy-nunn March 13, 2024 15:18
timothy-nunn
timothy-nunn requested changes Mar 14, 2024
View reviewed changes
Copy link
Contributor
@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor QOL thing

@clmould clmould requested a review from timothy-nunn March 14, 2024 09:54
@timothy-nunn timothy-nunn merged commit 4e3942e into main Mar 14, 2024
@timothy-nunn timothy-nunn deleted the 537-error-handling-for-negative-conductor-fraction-in-tf-cable branch March 14, 2024 10:17
chris-ashe pushed a commit that referenced this pull request Apr 22, 2024
@clmould @chris-ashe
correct error message when acs negative (#3092)
bfaf420 
* correct error message when acs negative

* Add to error message to suggest why acs is negative

* Remove duplicate acs
chris-ashe pushed a commit that referenced this pull request May 1, 2024
@clmould @chris-ashe
correct error message when acs negative (#3092)
af051be 
* correct error message when acs negative

* Add to error message to suggest why acs is negative

* Remove duplicate acs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothy-nunn timothy-nunn timothy-nunn approved these changes

Assignees

@clmould clmould

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error handling for negative conductor fraction in TF cable
2 participants
@clmould @timothy-nunn
0