Update FW docs part 1 #3592
Merged
Update FW docs part 1 #3592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3592 +/- ##
=======================================
Coverage 36.27% 36.28%
=======================================
Files 88 88
Lines 22231 22231
=======================================
+ Hits 8065 8066 +1
+ Misses 14166 14165 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3183d11 to
cf5b42a
Compare
There was a problem hiding this comment.
Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.
Files not reviewed (2)
- source/fortran/fwbs_variables.f90: Language not supported
- tests/regression/input_files/st_regression.IN.DAT: Language not supported
Comments suppressed due to low confidence (3)
process/fw.py:351
- The parameter name in the docstring (':param t:') does not match the function signature ('temp'). Consider updating the docstring to use 'temp' for consistency.
def fw_thermal_conductivity(self, temp: float) -> float:
documentation/proc-pages/eng-models/fw-blanket.md:87
- There appears to be a typographical error in the image title ('First walld'). Consider correcting it to 'First wall'.
<img title="First walld" src="../../images/first_wall.png">
documentation/proc-pages/eng-models/fw-blanket.md:147
- The formula contains a double '×' which may be a typographical error. Please verify and correct the expression if needed.
× ×
90f70b7 to
d223d37
Compare
timothy-nunn
requested changes
Apr 23, 2025
process/hcpb.py
Outdated
Comment on lines
43
to
44
| ccfe_hcpb_module.ip = int(output) | ||
| ccfe_hcpb_module.ofile = self.outfile |
There was a problem hiding this comment.
I removed these a while back iirc
j-a-foster
requested changes
Apr 30, 2025
a0a66f5 to
07a01d5
Compare
timothy-nunn
requested changes
May 1, 2025
… descriptions and improved formatting
…nductivity method with detailed parameter descriptions and references
…date related references throughout the codebase
…ers in Haaland equation and enhance documentation for clarity
…date related references throughout the codebase
…e roughness and radius parameters, and update related tests for improved clarity and functionality
…r heat transfer coefficient variable for clarity
…arameter descriptions in the Fw class
…od for improved code organization and clarity
…uracy. adjust expected values in tests
9a9829f to
cf9064b
Compare
…roved geometry handling
timothy-nunn
approved these changes
May 16, 2025
j-a-foster
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes changes to the documentation and codebase related to the first wall (FW) thermo-hydraulic model and calculations. The changes primarily focus on updating variable names, improving documentation clarity, and enhancing the calculation methods.
🔄 Variable changes
roughness->roughness_fw_channelDocumentation Updates:
documentation/proc-pages/eng-models/fw-blanket.mdto reflect the new naming conventions, such as changingroughnesstoroughness_fw_channeland adding detailed descriptions of the FW temperature calculation and heat transfer processes.Codebase Updates:
process/blanket_library.pyto use the new variableroughness_fw_channelin thethermo_hydraulic_modelandpressure_dropmethods.set_fw_geometryinprocess/fw.pyto set the geometry parameters for the first wall and updated thefw_tempmethod to use the new variable names and improve the calculation process.These changes enhance the clarity and accuracy of the first wall thermo-hydraulic model documentation and improve the consistency and reliability of the related codebase.
Checklist
I confirm that I have completed the following checks: