♻️ Write current profile, inductance and normalised beta relations as functions #3655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3655 +/- ##
==========================================
+ Coverage 36.36% 36.42% +0.06%
==========================================
Files 88 88
Lines 22108 22129 +21
==========================================
+ Hits 8039 8060 +21
Misses 14069 14069 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
j-a-foster
approved these changes
May 13, 2025
ym1906
pushed a commit
that referenced
this pull request
May 16, 2025
… functions (#3655) * ♻️ ✅ Add function for wesson current profile relation and add unit test * ✨ Add Wesson internal inductance calculation and corresponding unit test * ✨ Add Menard plasma internal inductance calculation and corresponding unit test * ✨ Add Wesson normalized beta limit calculation and corresponding unit test * ✨ Add calculate_beta_norm_max_original method and corresponding unit test * ✨ Add Menard normalized beta calculation method and corresponding unit test * ✨ Add E. Tholerus normalized beta upper limit calculation method and corresponding unit test
ym1906
pushed a commit
that referenced
this pull request
May 16, 2025
… functions (#3655) * ♻️ ✅ Add function for wesson current profile relation and add unit test * ✨ Add Wesson internal inductance calculation and corresponding unit test * ✨ Add Menard plasma internal inductance calculation and corresponding unit test * ✨ Add Wesson normalized beta limit calculation and corresponding unit test * ✨ Add calculate_beta_norm_max_original method and corresponding unit test * ✨ Add Menard normalized beta calculation method and corresponding unit test * ✨ Add E. Tholerus normalized beta upper limit calculation method and corresponding unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot
2C2D
be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Enhancements and Refactoring:
process/physics.pyto improve readability by grouping related calculations into distinct sections with clear headers. For example, sections for "Plasma Current Profile" and "Normalized Beta Limit" were added.Physicsclass for calculating Wesson, Menard, and Tholerus scaling laws for normalized beta and internal inductance. These methods encapsulate specific calculation logic, improving modularity and maintainability.Documentation Updates:
plasma_beta.mdandplasma_inductance.mdto provide additional context for the Wesson and Menard models, including their recommended usage and data sources.Unit Tests:
tests/unit/test_physics.pyfor new methods, ensuring correctness of calculations for normalized beta and internal inductance models.Minor Changes:
physics.pyfor better code clarity.Checklist
I confirm that I have completed the following checks: