8000 add tl;dr about failed quality jobs to pre-commit docs by clmould · Pull Request #3665 · ukaea/PROCESS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ PROCESS Public

add tl;dr about failed quality jobs to pre-commit docs #3665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add tl;dr about failed quality jobs to pre-commit docs #3665

wants to merge 2 commits into from

Conversation

clmould
Copy link
Collaborator
@clmould clmould commented May 16, 2025 •
edited
Loading

Description

Closes #1637
Added a tl;dr to the docs to say what to do if the quality job fails. This is how it looks in the docs:

image

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould linked an issue May 16, 2025 that may be closed by this pull request
Manual counterparts of pre-commit commands #1637
Open
2 tasks
@clmould clmould mentioned this pull request May 16, 2025
Open
2 tasks
@clmould clmould changed the title add to tl;dr about failed quality jobs to pre-commit docs add tl;dr about failed quality jobs to pre-commit docs May 16, 2025
@codecov-commenter
Copy link
codecov-commenter commented May 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.93%. Comparing base (519e881) to head (9a7a2da).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3665      +/-   ##
==========================================
+ Coverage   36.29%   37.93%   +1.64%     
==========================================
  Files          88       88              
  Lines       22212    24573    +2361     
==========================================
+ Hits         8062     9322    +1260     
- Misses      14150    15251    +1101

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould clmould force-pushed the 1637-manual-counterparts-of-pre-commit-commands branch from a8a5393 to 9a7a2da Compare May 16, 2025 13:33
@clmould clmould requested a review from timothy-nunn May 16, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothy-nunn timothy-nunn Awaiting requested review from timothy-nunn

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manual counterparts of pre-commit commands
2 participants
@clmould @codecov-commenter
0