8000 [WIP] New sankey plot proc by chris-ashe · Pull Request #3678 · ukaea/PROCESS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[WIP] New sankey plot proc #3678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

[WIP] New sankey plot proc #3678

wants to merge 11 commits into from

Conversation

chris-ashe
Copy link
Collaborator

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

chris-ashe added 10 commits June 6, 2025 15:45
@chris-ashe
Add plot_main_power_flow function to visualize plasma image in main plot
6d6e800
@chris-ashe
Enhance plot_main_power_flow function to include H&CD power supply vi…
785bdb9 
…sualization and update parameters for plasma image display
@chris-ashe
Enhance plot_main_power_flow function to visualize H&CD power supply …
148c346 
…parameters and improve annotation clarity
@chris-ashe
Add images for generator, turbine, and pylon to enhance power flow vi…
2fa7cd2 
…sualization in plot_main_power_flow function
@chris-ashe
Enhance plot_main_power_flow function to improve layout and add visua…
428bd5e 
…lizations for first wall, blanket, vacuum vessel, and divertor components
@chris-ashe
Enhance plot_main_power_flow function with additional power annotatio…
d162f86 
…ns and improved visual elements for clarity and detail
@chris-ashe
Enhance plot_main_power_flow function with additional annotations and…
74bbdd1 
… improved arrow visualizations for clarity in power flow representation
@chris-ashe
Refactor plot_main_power_flow function to improve code readability by…
9da0f4e 
… removing unnecessary blank lines and enhancing annotation formatting for clarity.
@chris-ashe
Enhance plot_main_power_flow function with detailed docstring and imp…
9afdffc 
…roved arrow annotations for better clarity in power flow representation
@chris-ashe
Linting fixes
c5988ef
@chris-ashe chris-ashe requested a review from Copilot June 11, 2025 10:04
@chris-ashe chris-ashe self-assigned this Jun 11, 2025
Copilot
Copilot AI reviewed Jun 11, 2025
View reviewed changes
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

@chris-ashe chris-ashe added Documentation Improvements or additions to documentation Output Files Issues related to the output data files Power Cycle labels Jun 11, 2025
@chris-ashe chris-ashe marked this pull request as ready for review June 11, 2025 10:04
@codecov-commenter
Copy link
codecov-commenter commented Jun 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0.60976% with 163 lines in your changes missing coverage. Please review.

Project coverage is 38.37%. Comparing base (c100264) to head (9b29a0e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
process/io/plot_proc.py 0.60% 163 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3678      +/-   ##
==========================================
+ Coverage   37.01%   38.37%   +1.36%     
==========================================
  Files          84       88       +4     
  Lines       21679    24254    +2575     
==========================================
+ Hits         8024     9307    +1283     
- Misses      13655    14947    +1292

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chris-ashe
Enhance plot_main_power_flow function with additional annotations, up…
9b29a0e 
…dated color schemes, and improved clarity in visual elements.
@chris-ashe chris-ashe changed the title 🎨 New sankey plot proc WIP New sankey plot proc Jun 11, 2025
@chris-ashe chris-ashe changed the title WIP New sankey plot proc [WIP] New sankey plot proc Jun 11, 2025
@timothy-nunn timothy-nunn marked this pull request as draft June 11, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@chris-ashe chris-ashe

Labels
Documentation Improvements or additions to documentation Output Files Issues related to the output data files Power Cycle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-ashe @codecov-commenter
0