Add a kludge to identify and avoid temp_margin failure #3688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothy-nunn
commented
Jun 12, 2025
| ) | ||
| # print(root_result) # Diagnostic for newton method | ||
| tmarg = t_zero_margin - thelium | ||
| if superconductors.current_density_margin(thelium, *arguments) < 0: |
There was a problem hiding this comment.
Suggested change
| if superconductors.current_density_margin(thelium, *arguments) < 0: | |
| if superconductors.current_density_margin(1e-6, *arguments) < 0: |
??
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3688 +/- ##
==========================================
- Coverage 38.13% 38.13% -0.01%
==========================================
Files 88 88
Lines 22470 22471 +1
==========================================
Hits 8570 8570
- Misses 13900 13901 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.