Set tf general methods 3 #3699
Merged
Set tf general methods 3 #3699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
861a2f0 to
8f7c5eb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3699 +/- ##
==========================================
+ Coverage 37.78% 37.95% +0.16%
==========================================
Files 88 88
Lines 22618 22613 -5
==========================================
+ Hits 8547 8583 +36
+ Misses 14071 14030 -41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…conductingTFCoil for improved clarity and consistency
e59a23e to
bce7dfe
Compare
clmould
requested changes
Jun 27, 2025
bce7dfe to
f964767
Compare
clmould
requested changes
Jun 30, 2025
Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>
clmould
approved these changes
Jul 1, 2025
OceanNuclear
pushed a commit
that referenced
this pull request
Jul 12, 2025
* Rename tfcind to tf_coil_self_inductance * 🔄 Refactor tf_coil_self_inductance calls in ResistiveTFCoil and SuperconductingTFCoil for improved clarity and consistency * 🔄 Update TfcindParam structure in test_tfcoil.py for improved clarity and consistency * Update documentation/proc-pages/eng-models/tf-coil.md Co-authored-by: clmould <86794332+clmould@users.noreply.github.com> --------- Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the calculation of the self-inductance of toroidal field (TF) coils by introducing a new, unified method
tf_coil_self_inductance. The changes streamline the codebase by replacing duplicated logic with a single implementation, improving maintainability and readability. Additionally, corresponding updates have been made to unit tests to ensure correctness and compatibility with the new method.Refactoring and Code Consolidation:
process/tf_coil.py: Added a new methodtf_coil_self_inductanceto replace the previoustfcindmethod. The new implementation consolidates the logic for calculating self-inductance, supports multiple TF coil configurations, and improves clarity with detailed parameter descriptions.process/resistive_tf_coil.py,process/superconducting_tf_coil.py, andprocess/tf_coil.py: Updated therunmethod in each file to usetf_coil_self_inductanceinstead of duplicating inductance calculation logic. [1] [2] [3]Unit Test Updates:
tests/unit/test_tfcoil.py: Modified theTfcindParamclass to include new parameters required bytf_coil_self_inductance. Added test cases for different TF coil configurations, including D-shaped and picture frame coils. Renamed the test function totest_tf_coil_self_inductanceto reflect the new method. [1] [2] [3] [4]## DescriptionChecklist
I confirm that I have completed the following checks: