Update portsz()
#3705
Merged
Update portsz()
#3705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… across documentation and code
…files for consistency and clarity.
…ncy across code and documentation
…consistency in method naming
… and consistency across documentation and code
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3705 +/- ##
==========================================
- Coverage 37.73% 36.91% -0.82%
==========================================
Files 88 88
Lines 22761 23308 +547
==========================================
+ Hits 8588 8605 +17
- Misses 14173 14703 +530 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…quations and clarifying the maximum tangency radius constraints.
… into the run method for improved clarity and efficiency
…nsistency across code and documentation
clmould
requested changes
Jul 10, 2025
documentation/proc-pages/eng-models/heating_and_current_drive/NBI/nbi_overview.md
Show resolved
Hide resolved
ec76673 to
f9273e2
Compare
… directly call calculate_beam_port_size for improved clarity and efficiency
f9273e2 to
b4625ed
Compare
clmould
approved these changes
Jul 10, 2025
clmould
added a commit
that referenced
this pull request
Jul 10, 2025
OceanNuclear
pushed a commit
that referenced
this pull request
Jul 12, 2025
* 🔄 Rename rtanbeam to radius_beam_tangency for clarity and consistency across documentation and code * 🔄 Updated variable names from beamwd to dx_beam_duct across multiple files for consistency and clarity. * 🔄 Rename rtanmax to radius_beam_tangency_max for clarity and consistency across code and documentation * 🔄 Rename portsz function to calculate_beam_port_size for clarity and consistency in method naming * 🔄 Rename variable frbeam to f_radius_beam_tangency_rmajor for clarity and consistency across documentation and code * 📝 Enhance documentation for neutral beam injection, adding detailed equations and clarifying the maximum tangency radius constraints. * 🔄 Refactor build process by consolidating beam port size calculations into the run method for improved clarity and efficiency * 🔄 Rename variable fportsz to fradius_beam_tangency for clarity and consistency across code and documentation * 🔄 Refactor test_calculate_beam_port_size to remove monkeypatching and directly call calculate_beam_port_size for improved clarity and efficiency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for the derivation of the beam access has been added to
nbi_overview.mdFunction has been refactorized to take inputs instead of changing globals
🔄 Renames
portsx()->calculate_beam_port_size()rtanbeam->radius_beam_tangencybeamwd->dx_beam_ductrtanmax->radius_beam_tangency_maxfrbeam->f_radius_beam_tangency_rmajorfportsz->fradius_beam_tangencyChecklist
I confirm that I have completed the following checks: