8000 🎨 Radial build `plot_proc` by chris-ashe · Pull Request #3708 · ukaea/PROCESS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

🎨 Radial build plot_proc #3708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 7, 2025
Merged

🎨 Radial build plot_proc #3708

merged 3 commits into from
Jul 7, 2025

Conversation

chris-ashe
Copy link
Collaborator
@chris-ashe chris-ashe commented Jul 7, 2025 •
edited
Loading

This pull request introduces updates to the plotting functionality in process/io/plot_proc.py and documentation changes to reflect these updates. The main addition is the implementation of a new radial build plot, along with adjustments to the PDF generation process to accommodate an additional page for this plot. Documentation updates ensure consistency with the new changes in the plotting code.

Code Changes: Plotting Enhancements

  • Added the plot_radial_build function to visualize the radial build of a fusion device as a horizontal stacked bar chart. This includes logic to handle components with zero thickness and adjust the order of components based on the i_tf_inside_cs flag. (process/io/plot_proc.py, process/io/plot_proc.pyR4628-R4801)
  • Updated the main_plot function to include the radial build plot (plot_radial_build) and reorganized subplot assignments for other plots. (process/io/plot_proc.py, process/io/plot_proc.pyR5612-R5656)
  • Modified the main function to create a new figure (page12) for the radial build plot and updated the PDF generation process to save and close this new page. (process/io/plot_proc.py,

Documentation Updates

  • Updated the section title in documentation/proc-pages/io/utilities.md to reflect the new 12-page PDF summary.
  • Adjusted figure captions and image references in documentation/proc-pages/usage/plotting.md to align with the new radial build plot and reorganized figures accordingly.

image

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe self-assigned this Jul 7, 2025
@chris-ashe chris-ashe added the Output Files Issues related to the output data files label Jul 7, 2025
@chris-ashe chris-ashe requested a review from j-a-foster July 7, 2025 12:11
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 1.40845% with 70 lines in your changes missing coverage. Please review.

Project coverage is 37.66%. Comparing base (05d0a8d) to head (1e4e785).

Files with missing lines Patch % Lines
process/io/plot_proc.py 1.40% 70 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3708      +/-   ##
==========================================
- Coverage   37.73%   37.66%   -0.08%     
==========================================
  Files          88       88              
  Lines       22761    22806      +45     
==========================================
+ Hits         8588     8589       +1     
- Misses      14173    14217      +44

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

j-a-foster
j-a-foster approved these changes Jul 7, 2025
View reviewed changes
Copy link
Collaborator
@j-a-foster j-a-foster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with radial build addition.

@chris-ashe chris-ashe merged commit 834ebbf into main Jul 7, 2025
18 checks passed
@chris-ashe chris-ashe deleted the radial_build_plot_proc branch July 7, 2025 13:07
OceanNuclear pushed a commit that referenced this pull request Jul 12, 2025
@chris-ashe @OceanNuclear
🎨 Radial build plot_proc (#3708)
9421d4b 
* 🔄 Add radial build plot function and update main_plot to include new figures

* 🔄 Implement radial build plotting function and integrate into main_plot

* 🎨 Update figures and captions in documentation for radial build plots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-a-foster j-a-foster j-a-foster approved these changes

Assignees

@chris-ashe chris-ashe

@j-a-foster j-a-foster

Labels
Output Files Issues related to the output data files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris-ashe @codecov-commenter @j-a-foster
0