8000 🔄 Add naming conventions for forces and torques in style guide by chris-ashe · Pull Request #3703 · ukaea/PROCESS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

🔄 Add naming conventions for forces and torques in style guide #3703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025

Conversation

chris-ashe
Copy link
Collaborator

This pull request updates the standards.md documentation to include naming conventions for forces and torques. These additions provide clarity on the prefixes to use for these physical quantities.

Documentation updates:

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe requested a review from Copilot July 2, 2025 08:08
@chris-ashe chris-ashe self-assigned this Jul 2, 2025
@chris-ashe chris-ashe added the Documentation Improvements or additions to documentation label Jul 2, 2025
@chris-ashe chris-ashe requested a review from j-a-foster July 2, 2025 08:09
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the development standards by specifying naming prefixes for physical quantities.

  • Introduces a “Forces” section recommending the for_ prefix.
  • Introduces a “Torques” section recommending the torq_ prefix.
Comments suppressed due to low confidence (1)

documentation/proc-pages/development/standards.md:383

  • Add a trailing period to this bullet so it matches the formatting of the Forces section and maintains consistency.
- Torques should start with the `torq_` prefix

@codecov-commenter
Copy link
codecov-commenter commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.57%. Comparing base (67e6966) to head (49ba9ba).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3703      +/-   ##
==========================================
- Coverage   37.82%   36.57%   -1.26%     
==========================================
  Files          88       88              
  Lines       22696    23650     +954     
==========================================
+ Hits         8584     8649      +65     
- Misses      14112    15001     +889     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chris-ashe chris-ashe force-pushed the add_torque_force_style_guide branch from 5e76186 to 49ba9ba Compare July 2, 2025 10:41
Copy link
Collaborator
@j-a-foster j-a-foster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with additions.

@chris-ashe chris-ashe merged commit 515f8c3 into main Jul 3, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0