Update portsz 1 #3716
Merged
Update portsz 1 #3716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clmould
requested changes
Jul 11, 2025
| g = \sqrt{e^2+f^2-2ef\cos{\phi}} | ||
| $$ | ||
|
|
||
| If the value of $g$ is geater than $c$, then: |
There was a problem hiding this comment.
Suggested change
| If the value of $g$ is geater than $c$, then: | |
| If the value of $g$ is greater than $c$, then: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3716 +/- ##
=======================================
Coverage 37.63% 37.63%
=======================================
Files 88 88
Lines 22830 22830
=======================================
Hits 8592 8592
Misses 14238 14238 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
clmould
approved these changes
Jul 11, 2025
5acbd70 to
332a907
Compare
clmould
approved these changes
Jul 11, 2025
OceanNuclear
pushed a commit
that referenced
this pull request
Jul 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on improving the clarity and consistency of variable naming in documentation and example data files related to neutral beam injection (NBI) models. It also introduces a detailed explanation of the beam tangency radius calculation and updates associated constraints.
Documentation updates:
Variable renaming for clarity:
frbeamtof_radius_beam_tangency_rmajorinculham_nb.mdto better describe its purpose as the ratio of beam tangency radius to plasma major radius. This change is consistently applied across equations and descriptions. [1] [2] [3] [4] [5]Beam tangency radius explanation:
radius_beam_tangency_max) innbi_overview.md. This includes geometric considerations and constraints based on TF coil dimensions.Example data files updates:
beamwdtodx_beam_ductin multiple example data files to align with the updated naming convention for the width of the neutral beam duct.These changes improve the readability and consistency of the documentation and example data files, making it easier for users to understand and work with the NBI models.
Checklist
I confirm that I have completed the following checks: