8000 📝 Update machine build documentation and add D-shaped first wall area… by chris-ashe · Pull Request #3712 · ukaea/PROCESS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

📝 Update machine build documentation and add D-shaped first wall area… #3712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

📝 Update machine build documentation and add D-shaped first wall area… #3712

wants to merge 2 commits into from

Conversation

chris-ashe
Copy link
Collaborator
@chris-ashe chris-ashe commented Jul 10, 2025 •
edited
Loading

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe self-assigned this Jul 10, 2025
@chris-ashe chris-ashe added Documentation Improvements or additions to documentation Machine Build labels Jul 10, 2025
@codecov-commenter
Copy link
codecov-commenter commented Jul 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.66%. Comparing base (834ebbf) to head (3fae0d9).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3712   +/-   ##
=======================================
  Coverage   37.66%   37.66%           
=======================================
  Files          88       88           
  Lines       22806    22806           
=======================================
  Hits         8589     8589           
  Misses      14217    14217

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chris-ashe
Enhance D-shaped first wall area plot with additional sliders and imp…
3fae0d9 
…roved layout

- Added sliders for first wall thickness and blanket upper height.
- Adjusted plot dimensions and ranges for better visualization.
- Updated calculations for first wall inboard height and left rectangle position to incorporate new parameters.
- Introduced horizontal lines for better clarity on divertor to plasma gaps.
- Refactored slider arrangement into two columns for improved UI.
- Updated output filename for saved HTML plot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chris-ashe chris-ashe

Labels
Documentation Improvements or additions to documentation Machine Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-ashe @codecov-commenter
0