8000 Create `pyproject.toml` file by pderrenger · Pull Request #5 · ultralytics/mobileclip · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Create pyproject.toml file #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 25, 2025
Merged

Create pyproject.toml file #5

merged 4 commits into from
Apr 25, 2025

Conversation

pderrenger
Copy link
Member
@pderrenger pderrenger commented Apr 25, 2025 •
edited by UltralyticsAssistant
Loading

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

This PR modernizes the packaging of MobileCLIP by switching to a pyproject.toml-based build system and removing legacy setup files. 📦✨

📊 Key Changes

  • Added a new pyproject.toml file to define project metadata, dependencies, and build configuration.
  • Removed old setup.py and requirements.txt files, consolidating all setup and dependency management into pyproject.toml.
  • Updated supported Python versions and clarified optional dependencies for full functionality.
  • Improved package discovery and inclusion of configuration files for distribution.

🎯 Purpose & Impact

  • Simplifies installation and packaging: Using pyproject.toml is the modern Python standard, making it easier for users and developers to install and maintain MobileCLIP.
  • Improves compatibility: Ensures better support with modern Python tooling and environments.
  • Clearer dependency management: All dependencies (core and optional) are now managed in one place, reducing confusion and potential errors.
  • Easier distribution: Streamlines the process for publishing and sharing the package, benefiting both users and contributors.

🚀 This update makes MobileCLIP more user-friendly and future-proof!

@UltralyticsAssistant UltralyticsAssistant added dependencies Dependency-related topics enhancement New feature or request labels Apr 25, 2025
@UltralyticsAssistant
Copy link
Member

👋 Hello @pderrenger, thank you for submitting a ultralytics/mobileclip 🚀 PR! To help ensure a smooth review and integration, please review the checklist below:

  • ✅ Define a Purpose: Make sure your PR description clearly outlines the purpose of your changes and links to any related issues. Commit messages should be clear, concise, and follow project conventions.
  • ✅ Synchronize with Source: Confirm your PR is up to date with the ultralytics/mobileclip main branch. If it's behind, update it by using the 'Update branch' button or running git pull and git merge main locally.
  • ✅ Ensure CI Checks Pass: All Ultralytics Continuous Integration (CI) checks should be passing. Please resolve any failing checks.
  • ✅ Update Documentation: If your changes modify or add new functionality, update the relevant documentation.
  • ✅ Add Tests: Where applicable, add or update tests to cover your modifications and ensure all tests are passing.
  • ✅ Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by commenting "I have read the CLA Document and I sign the CLA" below.
  • ✅ Minimize Changes: Keep your changes to the minimum required for your feature or fix. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For detailed contribution guidelines, see our Contributing Guide. If you have questions, please leave a comment here — an Ultralytics engineer will assist you soon! 🤖✨

Thank you for helping improve Ultralytics MobileCLIP! 🚀

@pderrenger pderrenger changed the title Update markdown files Create pyproject.toml file Apr 25, 2025
@pderrenger pderrenger merged commit 7aa2444 into main Apr 25, 2025
5 checks passed
@pderrenger pderrenger deleted the update branch April 25, 2025 00:08
@UltralyticsAssistant
Copy link
Member

🎉 Congratulations on this fantastic merge, @pderrenger and @glenn-jocher! As Thomas Edison once said, "There is a way to do it better—find it." Your efforts to modernize MobileCLIP's packaging embody this spirit of continuous improvement. By streamlining the build system with pyproject.toml and clarifying dependencies, you've made the project more accessible and robust for the whole community. Thank you for helping shape a more user-friendly and future-ready Ultralytics ecosystem! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Dependency-related topics enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pderrenger @UltralyticsAssistant @glenn-jocher
0