Dont push s3 details for event #996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missed in previous fix for this for one event type - disallowAdditionalFastqs
There was a problem hiding this comment.
Pull Request Overview
This PR updates the FASTQ set API to ensure that S3 details are not pushed for the disallowAdditionalFastqs event.
- Removed S3 details from the payload generated by fastq_set_obj.to_dict() during the disallowAdditionalFastqs event.
- Aligns event payload content with the intended security requirements for S3 details.
Comments suppressed due to low confidence (1)
lib/workload/stateless/stacks/fastq-manager/app/api/fastq_manager_api_tools/api/v1/routers/fastq_set.py:774
- Removing the 'include_s3_details=True' parameter ensures that S3 sensitive data is not pushed for the disallowAdditionalFastqs event. Confirm that this change aligns with the overall API design for event payloads across the system.
fastq_set_dict = fastq_set_obj.to_dict(include_s3_details=True)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
missed in previous fix for this for one event type - disallowAdditionalFastqs