fix: .cts should never be treated as esm
#226
Conversation
🦋 Changeset detectedLatest commit: 50dfdaa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis pull request introduces several modifications. It patches the synckit package to ensure Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant setupTsRunner
Caller->>setupTsRunner: call setupTsRunner(file, ext)
Note right of setupTsRunner: Evaluate file extension
alt ext == ".mjs"
setupTsRunner->>setupTsRunner: Set jsUseEsm = true
else ext == ".cjs"
setupTsRunner->>setupTsRunner: Set jsUseEsm = false
end
alt ext == ".mts" and ext != ".cts"
setupTsRunner->>setupTsRunner: Set tsUseEsm = true
else ext == ".cts"
setupTsRunner->>setupTsRunner: Set tsUseEsm = false
end
setupTsRunner-->>Caller: Return configuration
Possibly related PRs
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/helpers.tsOops! Something went wrong! :( ESLint: 9.23.0 Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@1stg/eslint-config' imported from /eslint.config.js 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (12)
🔇 Additional comments (9)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (5)
src/helpers.ts:120
- Ensure that 'ext' is properly initialized from 'workerPath' before this check, as an undefined or unexpected value could lead to incorrect module type resolution for TypeScript files.
if (!tsUseEsm && ext !== '.cts') {
README.md:251
- [nitpick] The updated capitalization for 'JounQin' improves consistency; please verify that this change aligns with all related documentation references.
+[JounQin]: https://github.com/JounQin
.github/workflows/size-limit.yml:6
- Confirm that restricting the branch filter to 'main' is intentional and that it doesn't inadvertently exclude other active branches.
+ - main
.github/workflows/pkg-pr-new.yml:30
- [nitpick] The explicit naming for the publish step enhances clarity; ensure that similar workflow steps follow consistent naming conventions.
+ - name: Publish
.github/workflows/ci.yml:65
- Removing the EFF_NO_LINK_RULES environment variable might affect linting behavior; please confirm that this change is fully intentional and tested.
PARSER_NO_WATCH: true
📊 Package size report -0.08%↓
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
|
@codecov-ai-reviewer review |
|
On it! We are reviewing the PR and will provide feedback shortly. |
size-limit report 📦
|
commit: |
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
=======================================
Coverage 95.80% 95.80%
=======================================
Files 4 4
Lines 334 334
Branches 156 155 -1
=======================================
Hits 320 320
Misses 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Report too large to display inline |
|
Summary by CodeRabbit