10000 refactor: target ES2020 to drop `tslib` dependency by JounQin · Pull Request #240 · un-ts/synckit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: target ES2020 to drop tslib dependency #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Al 8000 ready on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2025
Merged

refactor: target ES2020 to drop tslib dependency #240

merged 2 commits into from
May 17, 2025

Conversation

JounQin
Copy link
Member
@JounQin JounQin commented May 17, 2025

close #239


Important

Update target ECMAScript version to ES2020 and modify dependencies in package.json.

  • Dependencies:
    • Remove tslib from dependencies in package.json.
  • DevDependencies:
    • Update eslint to ^9.27.0.
    • Update ts-jest to ^29.3.4.
    • Update tsdown to ^0.11.10.

This description was created by Ellipsis for d480f1f. You can customize this summary. It will automatically update as commits are pushed.

Summary by CodeRabbit

  • Chores
    • Upgraded several development dependencies to their latest patch versions.
    • Removed an unused library from the project dependencies.
    • Updated the build target to ES2020, enabling support for newer JavaScript features.

@JounQin JounQin requested a review from Copilot May 17, 2025 09:35
@JounQin JounQin self-assigned this May 17, 2025
@JounQin JounQin added enhancement New feature or request dependencies labels May 17, 2025
Copy link
changeset-bot bot commented May 17, 2025

🦋 Changeset detected

Latest commit: d8435b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
synckit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor
coderabbitai bot commented May 17, 2025

Walkthrough

The changes update the TypeScript compilation target from ES2015 to ES2020 in the configuration file and remove the tslib dependency from the project. Additionally, several development dependencies are upgraded to newer patch versions. No modifications are made to code, scripts, or exported entities.

Changes

File(s) Change Summary
package.json Removed tslib from dependencies; upgraded eslint, ts-jest, and tsdown dev dependencies.
tsconfig.json Changed TypeScript target from ES2015 to ES2020.

Assessment against linked issues

Objective Addressed Explanation
Update TypeScript target to ES2020 and remove tslib dependency (#239)

Poem

A hop and a skip, the code’s up to date,
No more tslib, ES2020 is great!
With dependencies fresh and configs anew,
This bunny’s delighted—so should be you!
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between d480f1f and d8435b3.

📒 Files selected for processing (1)
  • .changeset/sweet-spies-shout.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .changeset/sweet-spies-shout.md
⏰ Context from checks skipped due to timeout of 90000ms (20)
  • GitHub Check: Lint and Test with Node.js 22 on windows-latest
  • GitHub Check: Lint and Test with Node.js 23 on ubuntu-latest
  • GitHub Check: Lint and Test with Node.js 22 on ubuntu-latest
  • GitHub Check: Lint and Test with Node.js 23 on windows-latest
  • GitHub Check: Lint and Test with Node.js 24 on windows-latest
  • GitHub Check: Lint and Test with Node.js 20 on windows-latest
  • GitHub Check: Lint and Test with Node.js 18.18 on ubuntu-latest
  • GitHub Check: Lint and Test with Node.js 18.18 on macos-latest
  • GitHub Check: Lint and Test with Node.js 20 on ubuntu-latest
  • GitHub Check: Lint and Test with Node.js 18.18 on windows-latest
  • GitHub Check: Lint and Test with Node.js 18 on windows-latest
  • GitHub Check: Lint and Test with Node.js 18 on macos-latest
  • GitHub Check: Lint and Test with Node.js 22 on windows-latest
  • GitHub Check: Lint and Test with Node.js 18 on windows-latest
  • GitHub Check: Lint and Test with Node.js 23 on macos-latest
  • GitHub Check: Lint and Test with Node.js 23 on windows-latest
  • GitHub Check: Lint and Test with Node.js 24 on windows-latest
  • GitHub Check: Lint and Test with Node.js 20 on windows-latest
  • GitHub Check: Lint and Test with Node.js 18 on macos-latest
  • GitHub Check: Lint and Test with Node.js 18.18 on windows-latest

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@JounQin JounQin changed the title feat: target es2020 instead refactor: target es2020 instead May 17, 2025
Copy link

Walkthrough

This pull request updates the target environment to ES2020 in the TypeScript configuration, reflecting a shift towards more modern JavaScript features. It also includes various dependency updates in package.json and yarn.lock, ensuring compatibility and leveraging improvements in newer versions.

Changes

File Summary
package.json Updated devDependencies and removed tslib from dependencies.
tsconfig.json Changed target from ES2015 to ES2020.
yarn.lock Updated lock file to reflect changes in package versions and dependencies.

Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the package dependencies by removing tslib and bumping several dev dependencies to their newest patch versions.

  • Remove tslib from runtime dependencies.
  • Upgrade eslint, ts-jest, and tsdown in devDependencies.
Comments suppressed due to low confidence (1)

package.json:64

  • Removing tslib may break runtime helper imports; verify that importHelpers is disabled in your tsconfig or re-add tslib if needed.
"tslib": "^2.8.1"

Copy link
codesandbox-ci bot commented May 17, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@JounQin JounQin changed the title refactor: target es2020 instead refactor: target ES2020 to drop tslib dependency May 17, 2025
Copy link
@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to d480f1f in 49 seconds. Click for details.
  • Reviewed 35 lines of code in 1 files
  • Skipped 2 files when reviewing.
  • Skipped posting 4 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. package.json:62
  • Draft comment:
    Removed 'tslib' dependency as expected for ES2020 target.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, stating that a dependency was removed due to a target change. It doesn't provide any actionable feedback or suggestions for improvement.
2. package.json:81
  • Draft comment:
    Bumped eslint from ^9.26.0 to ^9.27.0.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
3. package.json:94
  • Draft comment:
    Updated ts-jest from ^29.3.2 to ^29.3.4.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
4. package.json:98
  • Draft comment:
    Updated tsdown from ^0.11.9 to ^0.11.10.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_nVe0h0u7yINmbeAW

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
codecov bot commented May 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.79%. Comparing base (e37f455) to head (d8435b3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
- Coverage   95.80%   95.79%   -0.02%     
==========================================
  Files           4        4              
  Lines         334      333       -1     
  Branches      155      154       -1     
==========================================
- Hits          320      319       -1     
+ Misses         14       11       -3     
- Partials        0        3       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor
github-actions bot commented May 17, 2025

📊 Package size report   -0.9%↓

File Before After
lib/common.js 987 B -11.7%↓872 B
lib/common.js.map 1.2 kB -2.66%↓1.2 kB
lib/helpers.js 17.3 kB -2.54%↓16.9 kB
lib/helpers.js.map 15.3 kB -1.07%↓15.2 kB
lib/index.js 2.6 kB -4.71%↓2.5 kB
lib/index.js.map 2.5 kB -0.83%↓2.5 kB
package.json 4.3 kB -0.52%↓4.2 kB
Total (Includes all files) 102.0 kB -0.9%↓101.1 kB
Tarball size 26.6 kB -0.91%↓26.4 kB
Unchanged files
File Size
lib/common.d.ts 329 B
lib/constants.d.ts 1.8 kB
lib/constants.js 2.4 kB
lib/constants.js.map 2.3 kB
lib/helpers.d.ts 1.5 kB
lib/index.cjs 24.4 kB
lib/index.d.cts 5.8 kB
lib/index.d.ts 424 B
lib/types.d.ts 1.4 kB
lib/types.js 44 B
lib/types.js.map 102 B
LICENSE 1.1 kB
README.md 16.1 kB

🤖 This report was automatically generated by pkg-size-action

Copy link
Contributor
github-actions bot commented May 17, 2025

size-limit report 📦

Path Size
lib/index.js 861 B (-5.6% 🔽)

Copy link
pkg-pr-new bot commented May 17, 2025

Open in StackBlitz

npm i https://pkg.pr.new/synckit@240

commit: d8435b3

Copy link
sonarqubecloud bot commented 9E7A May 17, 2025

@JounQin JounQin merged commit e0caff5 into main May 17, 2025
54 of 55 checks passed
@JounQin JounQin deleted the feat/target branch May 17, 2025 09:52
@JounQin JounQin mentioned this pull request May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: target ES2020 to drop tslib dependency
1 participant
0