8000 feat: add common UI components by huynguyen-hl · Pull Request #4 · uncefact/tests-untp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add common UI components #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 26, 2024
Merged

feat: add common UI components #4

merged 4 commits into from
Jan 26, 2024

Conversation

huynguyen-hl
Copy link
Member

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

namhoang1604
namhoang1604 suggested changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator
@namhoang1604 namhoang1604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please correct the commit message?

@huynguyen-hl huynguyen-hl force-pushed the common-components branch 3 times, most recently from 307e021 to f56f968 Compare January 25, 2024 09:45
@huynguyen-hl huynguyen-hl changed the title chore: add common UI components feat: add common UI components Jan 25, 2024
@huynguyen-hl
Copy link
Member Author
huynguyen-hl commented Jan 25, 2024 •
edited
Loading

Can you please correct the commit message?

Yes, I just updated that commit message

namhoang1604
namhoang1604 previously approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator
@namhoang1604 namhoang1604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldhyen99
ldhyen99 previously approved these changes Jan 26, 2024
View reviewed changes
@huynguyen-hl huynguyen-hl dismissed stale reviews from ldhyen99 and namhoang1604 via e1eb75a January 26, 2024 08:13
@huynguyen-hl huynguyen-hl merged commit cf4655f into uncefact:next Jan 26, 2024
@ldhyen99 ldhyen99 mentioned this pull request Jun 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namhoang1604 namhoang1604 namhoang1604 approved these changes

@ldhyen99 ldhyen99 ldhyen99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huynguyen-hl @namhoang1604 @ldhyen99
91
0