8000 feat: add json form component to components package by ldhyen99 · Pull Request #5 · uncefact/tests-untp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add json form component to components package #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 26, 2024
Merged

feat: add json form component to components package #5

merged 4 commits into from
Jan 26, 2024

Conversation

ldhyen99
Copy link
Collaborator
@ldhyen99 ldhyen99 commented Jan 25, 2024 •
edited
Loading

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

image image

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

@ldhyen99 ldhyen99 changed the title feat: add json form component to components package contains unit tes… feat: add json form component to components package Jan 25, 2024
namhoang1604
namhoang1604 approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator
@namhoang1604 namhoang1604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

huynguyen-hl
huynguyen-hl approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member
@huynguyen-hl huynguyen-hl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldhyen99 ldhyen99 merged commit d7cd671 into uncefact:next Jan 26, 2024
@ldhyen99 ldhyen99 mentioned this pull request Jun 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namhoang1604 namhoang1604 namhoang1604 approved these changes

@huynguyen-hl huynguyen-hl huynguyen-hl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ldhyen99 @namhoang1604 @huynguyen-hl
0