10000 feat: determine version and type credential in untp playground by ldhyen99 Β· Pull Request #260 Β· uncefact/tests-untp Β· GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: determine version and type credential in untp playground #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: next
Choose a base branch
from

Conversation

ldhyen99
Copy link
Collaborator
@ldhyen99 ldhyen99 commented Mar 27, 2025

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

Currently, the UNTP playground uses hard-coded mapping within the source code to determine the relationship and versions of different credentials, including extensions like the livestock passport. This approach, where mappings for extensions and their versions are directly added to the code, is considered not scalable. Every time a new beta version is released or a new extension is introduced, the source code would need to be updated, making testing in the playground cumbersome.

To address this scalability issue, a new approach for dynamic version determination is being proposed and discussed. This method relies on examining the context URL found within the verifiable credential. The idea is to use the types of the credentials (present in the "type" array) and the context links to determine the credential type, what it extends (if it's an extension), and the versions of both.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“– Mock App docs site
  • πŸ“œ README.md
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

Copy link

Code Coverage Report

Lines Statements Branches Functions
Coverage: 82%
81.45% (3663/4497) 69% (875/1268) 72.89% (433/594)
Title Lines Statements Branches Functions
All packages Coverage: 82%
81.45% (3663/4497) 69% (875/1268) 72.89% (433/594)
Components Coverage: 84%
84.03% (516/614) 69.36% (120/173) 77.23% (95/123)
Mock A82E app Coverage: 71%
71.95% (372/517) 53.23% (74/139) 68.14% (77/113)
Services Coverage: 81%
79.29% (1038/1309) 64.88% (255/393) 75.71% (106/140)
UNTP test suite Coverage: 85%
85.75% (1090/1271) 81.35% (144/177) 67.21% (41/61)
VC test suite Coverage: 100%
100% (20/20) 100% (2/2) 100% (4/4)
UNTP Playground Coverage: 85%
82.5% (660/800) 73.05% (282/386) 72.61% (114/157)

@ldhyen99 ldhyen99 marked this pull request as ready for review March 31, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0