8000 feat: validate Credential config file by ldhyen99 · Pull Request #29 · uncefact/tests-untp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: validate Credential config file #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 18, 2024
Merged

feat: validate Credential config file #29

merged 14 commits into from
Mar 18, 2024

Conversation

ldhyen99
Copy link
Collaborator
@ldhyen99 ldhyen99 commented Mar 15, 2024 •
edited
Loading

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

@ldhyen99 ldhyen99 changed the title feat: check validate credential fields feat: validate Credential config file Mar 15, 2024
namhoang1604
namhoang1604 suggested changes Mar 18, 2024
View reviewed changes
namhoang1604
namhoang1604 previously approved these changes Mar 18, 2024
View reviewed changes
namhoang1604
namhoang1604 previously approved these changes Mar 18, 2024
View reviewed changes
huynguyen-hl
huynguyen-hl reviewed Mar 18, 2024
View reviewed changes
huynguyen-hl
huynguyen-hl reviewed Mar 18, 2024
View reviewed changes
@ldhyen99 ldhyen99 merged commit 717c0bd into next Mar 18, 2024
@ldhyen99 ldhyen99 deleted the feat/check_validate_credential_fields branch March 18, 2024 10:39
@ldhyen99 ldhyen99 mentioned this pull request Jun 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namhoang1604 namhoang1604 namhoang1604 approved these changes

@huynguyen-hl huynguyen-hl huynguyen-hl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ldhyen99 @namhoang1604 @huynguyen-hl
0