8000 CLDR-14737 Update adding-locales.md by DavidLRowe · Pull Request #4819 · unicode-org/cldr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

CLDR-14737 Update adding-locales.md #4819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

CLDR-14737 Update adding-locales.md #4819

wants to merge 13 commits into from

Conversation

DavidLRowe
Copy link
Contributor

CLDR-14737

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

Copy link

✨ This commit deployed to https://998393d7.cldr.pages.dev
✨ This PR deployed to https://pr4819.cldr.pages.dev

Changed Pages in the last commit:

@github-actions github-actions bot added the Site Update Updates docs/site label Jun 16, 2025
@DavidLRowe
Copy link
Contributor Author

Note: The ku-SY example under the "Country locales" heading is okay, however, script tags have been added to many of the current "ku*" locales now. There is no longer a ku_SY.xml, but rather ku_Latn_SY.xml. If anyone knows of a better example, please let me know.

Copy link

✨ This commit deployed to https://6f273877.cldr.pages.dev
✨ This PR deployed to https://pr4819.cldr.pages.dev

Changed Pages in the last commit:

Copy link

✨ This commit deployed to https://99f81de7.cldr.pages.dev
✨ This PR deployed to https://pr4819.cldr.pages.dev

Changed Pages in the last commit:

@DavidLRowe DavidLRowe requested review from srl295 and macchiati June 16, 2025 23:15
@DavidLRowe
Copy link
Contributor Author
DavidLRowe commented Jun 18, 2025

Or maybe this should reference CLDR-16611 ?

srl295
srl295 previously approved these changes Jun 18, 2025
Copy link
Member
@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested improvements but its' an improvement so hitting approve.

The site infrastructure ought to have an issue to automatically remove a leading https://cldr.unicode.org from URLs.

Co-authored-by: Steven R. Loomis <srl295@gmail.com>
Co-authored-by: Steven R. Loomis <srl295@gmail.com>
Copy link

✨ This commit deployed to https://d69e2d1b.cldr.pages.dev
✨ This PR deployed to https://pr4819.cldr.pages.dev

Changed Pages in the last commit:

Copy link

✨ This commit deployed to https://e3a0b8b0.cldr.pages.dev
✨ This PR deployed to https://pr4819.cldr.pages.dev

Changed Pages in the last commit:

- For the locale submission for "pap" (ticket [CLDR-14872](https://unicode-org.atlassian.net/browse/CLDR-14872) and pull request [PR#2542](https://github.com/unicode-org/cldr/pull/2542)), the region "CW" did not appear in the "timeData" information and needed to be added to the appropriate location.

#### Optional additions
- Plural rules are not needed until the locale needs to move beyond Basic level. If plural rule information is available, it could be added at the same time the locale is established. Add them to **common/supplemental/plurals.xml** and **common/supplemental/ordinals.xml**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we actually put that Plural rules are strong recommended? We've had several locales which have started contributing beyond basic without plural rules recently.

We may want to include what the impact is if plural rules are not available.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a "strongly recommended" line, but didn't quite know how to phrase the impact of not having them.

Copy link

✨ This commit deployed to https://501cba7f.cldr.pages.dev
✨ This PR deployed to https://pr4819.cldr.pages.dev

Changed Pages in the last commit:

Co-authored-by: Annemarie Apple <AEApple@users.noreply.github.com>
Copy link

✨ This commit deployed to https://4569f4dd.cldr.pages.dev
✨ This PR deployed to https://pr4819.cldr.pages.dev

Changed Pages in the last commit:

@DavidLRowe
Copy link
Contributor Author

@macchiati Would you have a few minutes to review this "Adding a locale" page?


#### Verify or update country/population/language/script Data

See [Update Language Script Info](/development/updating-codes/update-language-script-info) and [LikelySubtags and Default Content](/development/updating-codes/likelysubtags-and-default-content) for information on how to use the language, script, region and population data to verify that the information in [country_language_population.tsv](https://github.com/unicode-org/cldr/blob/main/tools/cldr-code/src/main/resources/org/unicode/cldr/util/data/country_language_population.tsv) and [language_script.tsv](https://github.com/unicode-org/cldr/blob/main/tools/cldr-code/src/main/resources/org/unicode/cldr/util/data/language_script.tsv) is correct. If changes are needed, correct an existing entry or add a new one as appropriate. Include references.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should discuss guidelines for markdown. I strongly favor semantic line breaks and link references.

Both make future diffing and reading the raw text much easier. The semantic line breaks are very easy to to (except that we can't do them in tables).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to enforce them, we either need a lint or a tool that automatically processes the markdown otherwise it is too hard to ensure consistency.

Copy link

✨ This commit deployed to https://01e6ce38.cldr.pages.dev
✨ This PR deployed to https://pr4819.cldr.pages.dev

Changed Pages in the last commit:

Copy link

✨ This commit deployed to https://9e981d17.cldr.pages.dev
✨ This PR deployed to https://pr4819.cldr.pages.dev

Changed Pages in the last commit:

@DavidLRowe
Copy link
Contributor Author

@macchiati @srl295 I think I've incorporated changes in response to feedback. Looking for reapproval.

Copy link
Member
@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes, OW looks good.

Co-authored-by: Mark Davis <mark@macchiato.com>
Co-authored-by: Mark Davis <mark@macchiato.com>
Copy link
github-actions bot commented Jul 2, 2025

✨ This commit deployed to https://3e8b15dd.cldr.pages.dev
✨ This PR deployed to https://pr4819.cldr.pages.dev

Changed Pages in the last commit:

Copy link
github-actions bot commented Jul 2, 2025

✨ This commit deployed to https://a8394f9c.cldr.pages.dev
✨ This PR deployed to https://pr4819.cldr.pages.dev

Changed Pages in the last commit:

Co-authored-by: Mark Davis <mark@macchiato.com>
Copy link
github-actions bot commented Jul 2, 2025

✨ This commit deployed to https://7e08591a.cldr.pages.dev
✨ This PR deployed to https://pr4819.cldr.pages.dev

Changed Pages in the last commit:

macchiati
macchiati previously approved these changes Jul 2, 2025
Copy link
github-actions bot commented Jul 2, 2025

✨ This commit deployed to https://ffad47f4.cldr.pages.dev
✨ This PR deployed to https://pr4819.cldr.pages.dev

Changed Pages in the last commit:

@DavidLRowe
Copy link
Contributor Author

Sorry, I added a bullet point so that the "Add the rules" line would be more obvious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Site Update Updates docs/site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0