8000 CLDR-18745 Create validate_units.py by preetsojitra2712 · Pull Request #4829 · unicode-org/cldr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

CLDR-18745 Create validate_units.py #4829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

CLDR-18745 Create validate_units.py #4829

merged 1 commit into from
Jul 1, 2025

Conversation

preetsojitra2712
Copy link
Contributor
@preetsojitra2712 preetsojitra2712 commented Jun 24, 2025 •
edited by younies
Loading

CLDR-18745

  • Reads the English “long” unit definitions from units.json

  • Sends the flattened patterns to an LLM for a brief analysis

  • Checks correctness with an “All correct?” prompt, plus:

    • Missing-prefix detection
    • Line-count verification (via LLM and locally in Python)

  • Supports interactive overrides of each prompt (or hit Enter to use the defaults)

  • This PR completes the ticket.

@preetsojitra2712
Copy link
Contributor Author

@younies Can you please review this PR? It’s ready for your review and aligns with the script logic we discussed.

@macchiati
Copy link
Member
macchiati commented Jun 25, 2025 via email

@preetsojitra2712 preetsojitra2712 marked this pull request as draft June 25, 2025 01:33
@preetsojitra2712 preetsojitra2712 marked this pull request as ready for review June 25, 2025 06:22
@preetsojitra2712 preetsojitra2712 marked this pull request as draft June 25, 2025 06:26
@preetsojitra2712 preetsojitra2712 marked this pull request as ready for review June 25, 2025 06:27
@preetsojitra2712
Copy link
Contributor Author
preetsojitra2712 commented Jun 25, 2025 •
edited by younies
Loading
Screenshot 2025-06-24 at 11 54 06 PM

Hello , I am unable to add a reviewer. can someone give me rights please.

Thank you

@younies younies self-requested a review June 25, 2025 12:43
@younies
Copy link
Member
younies commented Jun 25, 2025 •
edited
Loading

Hi Preet, good start!

For PRs to CLDR, we need to start the title with a CLDR ticket. In our case, we will use CLDR-18745.
• This means the title should be: CLDR-18745 Create validate_units.py

Also, you need to ensure that the branch has only one commit with a message the same as the title.

@younies younies changed the title Create validate_units.py CLDR-18745 Create validate_units.py Jun 25, 2025
@preetsojitra2712
Copy link
Contributor Author

Yeah Got it @younies

Thank you.

preetsojitra2712 added a commit to p 8000 reetsojitra2712/cldr that referenced this pull request Jun 25, 2025
@preetsojitra2712
CLDR-18745 Create validate_units.py
951931c 
See unicode-org#4829
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

preetsojitra2712 added a commit to preetsojitra2712/cldr that referenced this pull request Jun 30, 2025
@preetsojitra2712
CLDR-18745 Create validate_units.py
5ed808a 
See unicode-org#4829
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@younies younies closed this Jun 30, 2025
@younies younies reopened this Jun 30, 2025
@younies younies closed this Jun 30, 2025
@younies younies reopened this Jun 30, 2025
preetsojitra2712 added a commit to preetsojitra2712/cldr that referenced this pull request Jun 30, 2025
@preetsojitra2712
CLDR-18745 Create validate_units.py
16d6a52 
See unicode-org#4829
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

preetsojitra2712 added a commit to preetsojitra2712/cldr that referenced this pull request Jun 30, 2025
@preetsojitra2712
CLDR-18745 Create validate_units.py
4e252f0 
See unicode-org#4829
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@younies younies closed this Jun 30, 2025
@younies younies reopened this Jun 30, 2025
preetsojitra2712 added a commit to preetsojitra2712/cldr that referenced this pull request Jun 30, 2025
@preetsojitra2712
CLDR-18745 Create validate_units.py
3de7035 
See unicode-org#4829
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@younies younies changed the title CLDR-18745 Create validate_units.py CLDR-18745 Create validate_units.py Jun 30, 2025
younies
younies approved these changes Jun 30, 2025
View reviewed changes
Copy link
Member
@younies younies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve and we will follow with a PR as discussed offline

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@younies younies merged commit 94cfc72 into unicode-org:main Jul 1, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younies younies younies approved these changes

Assignees

@preetsojitra2712 preetsojitra2712

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@preetsojitra2712 @macchiati @younies
0