8000 CLDR-17354 offer to reload instead of failing with obscure message when navigating by srl295 · Pull Request #4821 · unicode-org/cldr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

CLDR-17354 offer to reload instead of failing with obscure message when navigating #4821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025

Conversation

srl295
Copy link
Member
@srl295 srl295 commented Jun 19, 2025
  • make loadAllRows async
  • check the fetch result in loadAllRows - throw exception if fetch is failing rather than trying to decode JSON
  • show a popup on loadAllRows failure to suggest reload
  • add an exception parameter to cldrNotify.openWithHtml
image

CLDR-17354

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

…en navigating

- make loadAllRows async
- check the fetch result in loadAllRows - throw exception if fetch is failing rather than trying to decode JSON
- show a popup on loadAllRows failure to suggest reload
- add an exception parameter to cldrNotify.openWithHtml
@srl295 srl295 self-assigned this Jun 19, 2025
@srl295 srl295 merged commit ca4b6b8 into unicode-org:main Jun 30, 2025
16 checks passed
@srl295 srl295 deleted the cldr-17354/error-when-advancing branch June 30, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0