8000 CLDR-17707 adjust "cv" plural rule by DavidLRowe · Pull Request #4830 · unicode-org/cldr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

CLDR-17707 adjust "cv" plural rule #4830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2025
Merged

CLDR-17707 adjust "cv" plural rule #4830

merged 2 commits into from
Jul 3, 2025

Conversation

DavidLRowe
Copy link
Contributor

CLDR-17707

  • This PR completes the ticket (building on the previous PR)

The previous PR on this ticket added plural rules for Chuvash "cv" after identifying the need for "zero", "one", "other", but in the interests of quickly enabling the extra categories, "cv" was added to the existing "ksh" entry. This PR removes "cv" from the "ksh" entry and makes a separate "cv" entry.

ALLOW_MANY_COMMITS=true

@DavidLRowe
Copy link
Contributor Author

Initially (after the first commit), the PR failed with the information:

TestDigitPluralCompleteness
Error:  (TestSupplementalInfo.java:747)  Error: : cv, 2, zero: expected true, got false
Error:  (TestSupplementalInfo.java:747)  Error: : cv, 3, zero: expected true, got false
Error:  (TestSupplementalInfo.java:747)  Error: : cv, 4, zero: expected true, got false
To fix the above, review the following, then replace in TestDigitPluralCompleteness
{"cv", "zero", "0"},	// n = 0

After adding the indicated line to TestSupplementalInfo.java, the tests passed. Hopefully that was the correct action to take to correct the test failure!

@DavidLRowe
Copy link
Contributor Author
DavidLRowe commented Jun 26, 2025 •
edited by jira bot
Loading

Discussion of the categories and the numeric values for each is in the ticket CLDR-17707

@DavidLRowe DavidLRowe merged commit 06be565 into main Jul 3, 2025
21 checks passed
@DavidLRowe DavidLRowe deleted the CLDR-17707a branch July 3, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macchiati macchiati macchiati approved these changes

@srl295 srl295 Awaiting requested review from srl295

@AEApple AEApple Awaiting requested review from AEApple

Assignees

@DavidLRowe DavidLRowe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidLRowe @macchiati
0