8000 feat(library): Introduce SQLite 3.44 as library by prasoon054 · Pull Request #163 · unikraft/catalog · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(library): Introduce SQLite 3.44 as library #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(library): Introduce SQLite 3.44 as library #163

wants to merge 1 commit into from

Conversation

prasoon054
Copy link

The sqlite example previously didn't work (it had mistakes in kraftfile and an empty dockerfile). Fixed it using information from "Adding applications to the catalog" guide.
8000

@razvand razvand requested review from StefanJum and mariapana March 13, 2025 04:36
@razvand razvand self-assigned this Mar 13, 2025
@razvand razvand added the enhancement New feature or request label Mar 13, 2025
@StefanJum
Copy link
Member

Hi @prasoon054. This was supposed to be a native build, not a bincompat build. This means no Dockerfile or base image was required.
What you did here is a completely different way than it was initially, which means I would put it in a different directory. Check the sqlite version that the docker image that you used has, and then create a new directory, library/sqlite/XX with the contents of this PR, and leave the initial directory as it is. Thank you.

@prasoon054
Copy link
Author

Hi @StefanJum
I've made the necessary changes. Please take a look when you have a moment. Sorry for being inactive recently, I had to travel due to an emergency. Thank you!

@StefanJum
Copy link
Member

Thanks @prasoon054. The 3.44 version works fine. Please undo any changes to the original 3.40 version. The PR should be only one commit (squash them) that adds the 3.44 sqlite version.
8000

@prasoon054
Copy link
Author

Thanks for pointing that out @StefanJum . I removed previous commits. Please have a look.

@prasoon054 prasoon054 changed the title Modified SQLite example feat(library): Introduce SQLite 3.44 as library Mar 23, 2025
StefanJum
StefanJum requested changes Mar 24, 2025
View reviewed changes
Copy link
Member
@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, only a few more small things.
See the inlines, and also follow the commit format that you see in the older commits (that is, commit title feat(library)..... and a signed-off commit). I think it's all good besides that.

@StefanJum
Copy link
Member

@prasoon054 you need to sign off the commit (use -s when doing git commit) https://docs.pi-hole.net/guides/github/how-to-signoff/

@prasoon054
Copy link
Author
prasoon054 commented Mar 24, 2025 •
edited
Loading

Done! Please review it now. Missed the signing part earlier.

@StefanJum
Copy link
Member

You also need to use your full name (firstname lastname) :)

StefanJum
StefanJum approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member
@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment and it's ok by me. @mariapana @razvand take a look plese.

@prasoon054
feat(library): Introduce SQLite 3.44 as library
9d3cc00 
Signed-off-by: Prasoon Kumar <prasoonkumar054@gmail.com>

feat(library): Introduce SQLite 3.44 as library

Signed-off-by: Prasoon Kumar <prasoonkumar054@gmail.com>

feat(library): Introduce SQLite 3.44 as library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanJum StefanJum StefanJum approved these changes

@mariapana mariapana Awaiting requested review from mariapana

Assignees

@razvand razvand

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prasoon054 @StefanJum @razvand
0