Caddy base runtime #177
Merged
Caddy base runtime #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razvand
requested changes
Apr 27, 2025
There was a problem hiding this comment.
See my comments. Improve your commit message. Use present tense. Use Caddy instead of caddy. Add rationale / reason for using base (to increase transparency in the contents of the application filesystem and the build steps).
Read carefully and follow rigorously the instructions into doing good Git commits.
See also the commit history in the catalog repository and follow the same syntax and contents as those.
Be careful, attentive and rigorous.
fa735d4 to
5e08ac2
Compare
razvand
approved these changes
May 10, 2025
There was a problem hiding this comment.
Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io
f5c0847 to
e59ac07
Compare
Introduce a new version of the Caddy example that uses the base runtime The base example is used to increase transparency in the contents of the application filesystem and the build steps. Signed-off-by: Vlad-Marin UNGUREANU <vlad.ungureanu1808@stud.acs.upb.ro>
Introduced a new version of the Node18 example that uses the base runtime. The base version is used to increase transparency in the contents of the application filesystem and the build steps. Signed-off-by: Vlad-Marin UNGUREANU <vlad.ungureanu1808@stud.acs.upb.ro>
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new version of the caddy example that uses the base runtime.