Fix an issue with the effect variable linearizing patch #2907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rewriting was introducing empty effect lists, but this is a problem
for effect signatures in an ability, which rely on there not being any
effect ascriptions except the one for the ability being defined on the
arrow spine. E.G.
a -> b -> c ->{A} d
is okay, but:
a ->{} b ->{} c ->{A} d
appears like the main effect happens on the first arrow to the checker.
pchiusano
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rewriting was accidentally inserting empty row in every spot without an ability variable. Since this is how the type system tells the arity of an effect in an ability in some spots, it was breaking that. It's possible it caused other issues, too.