8000 [DRAFT] Add checking id-token issuer against known/configured value. by creechy · Pull Request #841 · unitycatalog/unitycatalog · GitHub

More Web Proxy on the site http://driver.im/

[DRAFT] Add checking id-token issuer against known/configured value. #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

creechy wants to merge 1 commit into unitycatalog:main from creechy:fix-configure-check-issuer

Collaborator

creechy commented

PR Checklist

A description of the changes is added to the description of this PR.
If there is a related issue, make sure it is linked to this PR.
If you've fixed a bug or added code that should be tested, add tests!
If you've added or modified a feature, documentation in docs is updated

Description of changes

This adds an additional validation during token creation that the issuer of the incoming id-token matches the known/configured issuer.


          Add checking id-token issuer against known/configured value.

f5ab076

Collaborator Author

creechy commented

@dan1elt0m here's a draft enhancement to add issuer validation.

dan1elt0m commented

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tdas Awaiting requested review from tdas tdas will be requested when the pull request is marked ready for review tdas is a code owner

dennyglee Awaiting requested review from dennyglee dennyglee will be requested when the pull request is marked ready for review dennyglee is a code owner

rameshchandra Awaiting requested review from rameshchandra rameshchandra will be requested when the pull request is marked ready for review rameshchandra is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet

0