build: Move dep versions to Versions scala object #1007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacek Laskowski <jacek@japila.pl>
c0ef247 to
a3f533d
Compare
|
@johanl-db Please review and approve 🙏 |
Signed-off-by: Jacek Laskowski <jacek@japila.pl>
Signed-off-by: Jacek Laskowski <jacek@japila.pl>
ec9d0ce to
312f428
Compare
johanl-db
reviewed
May 19, 2025
Comment on lines
+2
to
+12
| val antlrVersion = "4.9.3" | ||
| val deltaVersion = "3.2.1" | ||
| val jacksonVersion = "2.15.0" | ||
| val log4jVersion = "2.24.3" | ||
| val openApiToolsJacksonBindNullableVersion = "0.2.6" | ||
| val orgApacheHttpVersion = "4.5.14" | ||
| val scala212 = "2.12.15" | ||
| val scala213 = "2.13.14" | ||
| val slf4jVersion = "2.0.13" | ||
| val spark3Version = "3.5.3" | ||
| val spark4Version = "4.0.0" |
There was a problem hiding this comment.
nit: can you split the versions into separate groups:
- scala versions
- delta/spark
- other dependencies
| object Versions { | ||
| val antlrVersion = "4.9.3" | ||
| val deltaVersion = "3.2.1" | ||
| val jacksonVersion = "2.15.0" |
There was a problem hiding this comment.
There were two jackson versions used before: 2.15.0 and 2.17.0. This effectively downgrades the version for part of the targets, we'll need to define two separate jackson versions. I'd let unifying versions used for a later change, this may create more issues than it solves
Comment on lines
+11
to
+12
| val spark3Version = "3.5.3" | ||
| val spark4Version = "4.0.0" |
There was a problem hiding this comment.
spark4Version isn't used, it's probably simpler to have a single sparkVersion since we will only support a single spark version at least for now
There was a problem hiding this comment.
Ah, right. It's for the upcoming PRs! 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
project/Versions.scalascala object with the dependencies shared across sbt modulesVersionsbuild objectbyte-buddydependency (as not needed, yet caused some Spark 4 integration issues)