8000 fix: Split by case should take space into account by noootwo · Pull Request #98 · unjs/scule · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Split by case should take space into account #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: Split by case should take space into account #98

wants to merge 4 commits into from

Conversation

noootwo
Copy link
@noootwo noootwo commented Nov 21, 2024 •
edited
Loading

fix #95
fix #92

I think for the titleCase, the , should not be took into account.

@noootwo
Copy link
Author
noootwo commented Nov 21, 2024 •
edited
Loading

It seem all punctuation needs to be preserved, do we need to take all punctuation into account and filter them at titleCase?

@codecov Codecov
Copy link
codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (32ee7f5) to head (c0a6e9a).
Report is 17 commits behind head on main.

Additional details and impacted files 
@@        
8000
    Coverage Diff            @@
##              main       #98   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          340       364   +24     
  Branches        39        45    +6     
=========================================
+ Hits           340       364   +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

pi0
pi0 reviewed Nov 21, 2024
View reviewed changes
@pi0
Copy link
Member
pi0 commented Nov 21, 2024 •
edited
Loading

It seem all punctuation needs to be preserved

I think that would make sense. Little bit tricky as makes change potential behavior breaking change.

I suggest to go one with this PR as-is and another followup later for v2

@noootwo
Copy link
Author
noootwo commented Nov 22, 2024 •
edited
Loading

It seem all punctuation needs to be preserved

I think that would make sense. Little bit tricky as makes change potential behavior breaking change.

I suggest to go one with this PR as-is and another followup later for v2

Ok, this PR is ready

When will the follow-up work be planned? I 'd be happy to help.

@Eazash Eazash mentioned this pull request Jan 15, 2025
Open
@43081j 43081j mentioned this pull request Mar 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent casing Split by case should take , and space into account
2 participants
@noootwo @pi0
0