8000 fix(preset-wind4)!: abandon css theme variables hyphenatable by zyyv · Pull Request #4592 · unocss/unocss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(preset-wind4)!: abandon css theme variables hyphenatable #4592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 16, 2025
Merged

Conversation

zyyv
Copy link
Member
@zyyv zyyv commented Apr 15, 2025

close #4579

This pr changes are as follows:
The theme preflights preset by unocss wind4 is different from tailwind4. We will generate all subkeys of the practical key of the theme and keep the original naming rules of the key.

For example, --fontWeight-DEFAULT will not hyphenate on fontWeight, and will not remove DEFAULT, so as to ensure that all subkeys are generated and unocss will not interfere with the user's subsequent customization of the theme.

@zyyv zyyv requested a review from antfu as a code owner April 15, 2025 08:16
Copy link
netlify bot commented Apr 15, 2025

Deploy Preview for unocss ready!

Name Link
🔨 Latest commit 044ec4f
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/67ff66a46525ff000820e5ba
😎 Deploy Preview https://deploy-preview-4592--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
pkg-pr-new bot commented Apr 15, 2025

Open in StackBlitz

commit: 044ec4f

@zyyv zyyv changed the title fix(preset-wind4): abandon css theme variables hyphenatable fix(preset-wind4)!: abandon css theme variables hyphenatable Apr 16, 2025
@zyyv zyyv merged commit f83c961 into main Apr 16, 2025
12 checks passed
@zyyv zyyv deleted the perf-theme branch April 16, 2025 08:30
zyyv added a commit that referenced this pull request Apr 18, 2025
@NikitaVelixJob
Copy link

@zyyv hello! When it will be merged? I have the same issue with different colors. Thank you!

@zyyv
Copy link
Member Author
zyyv commented May 2, 2025

@zyyv hello! When it will be merged? I have the same issue with different colors. Thank you!

Could you open a new issue report it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preset-wind4 colors declaration opacity is incorrect
2 participants
0